Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Vision logo detection#2235

Merged
daspecster merged 1 commit into
googleapis:mastergoogleapis/google-cloud-python:masterfrom
daspecster:vision-logo-detectiondaspecster/google-cloud-python:vision-logo-detectionCopy head branch name to clipboard
Sep 10, 2016
Merged

Vision logo detection#2235
daspecster merged 1 commit into
googleapis:mastergoogleapis/google-cloud-python:masterfrom
daspecster:vision-logo-detectiondaspecster/google-cloud-python:vision-logo-detectionCopy head branch name to clipboard

Conversation

@daspecster

@daspecster daspecster commented Sep 1, 2016

Copy link
Copy Markdown
Contributor

Based off #2224.

This adds EntityAnnotation, which is used by LOGO_DETECTION, LANDMARK_DETECTION, LABEL_DETECTION and TEXT_DETECTION.

Small PRs for the other three detection types will follow.

I'll rebase this after #2224 gets merged in.

@daspecster daspecster added the api: vision Issues related to the Cloud Vision API. label Sep 1, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 1, 2016
@daspecster daspecster added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 1, 2016
@daspecster daspecster force-pushed the vision-logo-detection branch 2 times, most recently from 5b20369 to 81cb07c Compare September 1, 2016 18:05
@daspecster daspecster force-pushed the vision-logo-detection branch 3 times, most recently from 7773a38 to c404c65 Compare September 9, 2016 17:32
@daspecster daspecster removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 9, 2016
@daspecster

Copy link
Copy Markdown
Contributor Author

OK! @tseaver, I think this one is ready to go.

Comment thread google/cloud/vision/entity.py Outdated


class EntityAnnotation(object):
"""Representation of an entity returned from the Vision API."""

This comment was marked as spam.

This comment was marked as spam.

@tseaver

tseaver commented Sep 9, 2016

Copy link
Copy Markdown
Contributor

LGTM

@daspecster

Copy link
Copy Markdown
Contributor Author

Awesome thanks!

@daspecster

Copy link
Copy Markdown
Contributor Author

vercies -> vertices...

@daspecster daspecster force-pushed the vision-logo-detection branch from c49c675 to 028be63 Compare September 9, 2016 20:46
@daspecster daspecster force-pushed the vision-logo-detection branch from 028be63 to 67ba8e5 Compare September 10, 2016 00:26
@daspecster daspecster merged commit f834020 into googleapis:master Sep 10, 2016
@dhermes dhermes mentioned this pull request Sep 19, 2016
@daspecster daspecster deleted the vision-logo-detection branch January 24, 2017 15:17
parthea added a commit that referenced this pull request Nov 24, 2025
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: ohmayr <omairn@google.com>
parthea pushed a commit that referenced this pull request Apr 1, 2026
* Revert "fix: Correct connection normalization in blob system tests (#2222)"

This reverts commit a0e1e50e47c758bdceb54d04180ed36b35cf2e35.

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: vision Issues related to the Cloud Vision API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.