Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Make handwritten JSON documents more uniform#2171

Merged
dhermes merged 3 commits into
googleapis:mastergoogleapis/google-cloud-python:masterfrom
dhermes:update-toc-jsondhermes/google-cloud-python:update-toc-jsonCopy head branch name to clipboard
Aug 23, 2016
Merged

Make handwritten JSON documents more uniform#2171
dhermes merged 3 commits into
googleapis:mastergoogleapis/google-cloud-python:masterfrom
dhermes:update-toc-jsondhermes/google-cloud-python:update-toc-jsonCopy head branch name to clipboard

Conversation

@dhermes

@dhermes dhermes commented Aug 23, 2016

Copy link
Copy Markdown
Contributor

Also

  • removing no longer needed toc-all.json
  • removing a section of toc.json in exceptions that didn't belong

Used the following script to update the content:

import json

files = [
    'docs/json/json/master/index.json',
    'docs/json/json/master/toc.json',
    'docs/json/manifest.json',
]

for filename in files:
    with open(filename, 'rb') as file_obj:
        content = json.load(file_obj)
    with open(filename, 'wb') as file_obj:
        json.dump(content, file_obj, indent=2, sort_keys=True,
                  separators=(',', ': '))  # Added separators later
        file_obj.write('\n')  # Added later

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 23, 2016
@daspecster

Copy link
Copy Markdown
Contributor

LGTM

@dhermes

dhermes commented Aug 23, 2016

Copy link
Copy Markdown
Contributor Author

@daspecster This will also break #2167, so I'll hold off on merging until you get it in 😉

Ping me though so I don't forget?

@daspecster

Copy link
Copy Markdown
Contributor

Ok yeah, just waiting on travis again... ⏳

@dhermes

dhermes commented Aug 23, 2016

Copy link
Copy Markdown
Contributor Author

Just rebased after #2167. Note that I added a newline to the end of each JSON file and also used custom json separators since by default a trailing space is used after the comma separator.

@daspecster

Copy link
Copy Markdown
Contributor

LGTM.

@dhermes dhermes merged commit 94c2743 into googleapis:master Aug 23, 2016
@dhermes dhermes deleted the update-toc-json branch August 23, 2016 22:37
@dhermes dhermes mentioned this pull request Sep 19, 2016
parthea pushed a commit that referenced this pull request Mar 6, 2026
#2171)

* Add ability to set autodetect_schema query_param

* fixup! Add ability to set autodetect_schema query_param

* fixup! Add ability to set autodetect_schema query_param

* fixup! Add ability to set autodetect_schema query_param

---------

Co-authored-by: Chalmer Lowe <chalmerlowe@google.com>
parthea pushed a commit that referenced this pull request Apr 1, 2026
* chore: Add cleanup step for old UDFs in anonymous dataset

* fix

* fix

* fix with some test code

* fix

* no retry

* fix retry

* disable doctest

* testing - increase timeout

* revert timout

* add warning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.