Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Add Sphinx as a dependency for linting#2019

Merged
daspecster merged 1 commit into
googleapis:mastergoogleapis/google-cloud-python:masterfrom
daspecster:fix-lint-sphinx-depdaspecster/google-cloud-python:fix-lint-sphinx-depCopy head branch name to clipboard
Jul 22, 2016
Merged

Add Sphinx as a dependency for linting#2019
daspecster merged 1 commit into
googleapis:mastergoogleapis/google-cloud-python:masterfrom
daspecster:fix-lint-sphinx-depdaspecster/google-cloud-python:fix-lint-sphinx-depCopy head branch name to clipboard

Conversation

@daspecster

@daspecster daspecster commented Jul 22, 2016

Copy link
Copy Markdown
Contributor

First seen #1946 (comment)

screen shot 2016-07-22 at 6 10 03 pm

Not sure how this got through?

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 22, 2016
@daspecster daspecster force-pushed the fix-lint-sphinx-dep branch from e3a5018 to 554285b Compare July 22, 2016 22:11
@daspecster daspecster mentioned this pull request Jul 22, 2016
Merged
@waprin

waprin commented Jul 22, 2016

Copy link
Copy Markdown
Contributor

lgtm

@daspecster daspecster merged commit 04a2543 into googleapis:master Jul 22, 2016
@dhermes

dhermes commented Jul 22, 2016

Copy link
Copy Markdown
Contributor

I am 👎 on the quick merge without a more in-depth investigation. I'm pretty sure this snuck in because our [pep8] settings aren't getting picked up after the switch to pycodestyle

@daspecster

daspecster commented Jul 22, 2016 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Sorry, I can revert. I looked and the offending line is https://github.com/GoogleCloudPlatform/gcloud-python/blob/master/scripts/verify_included_modules.py#L119

Which is called from https://github.com/GoogleCloudPlatform/gcloud-python/blob/master/tox.ini#L153 actually and not the pep8 stuff AFAICT.

@waprin

waprin commented Jul 22, 2016

Copy link
Copy Markdown
Contributor

Also sorry if you think it was too hasty but it did fix my PR.

@daspecster

daspecster commented Jul 22, 2016

Copy link
Copy Markdown
Contributor Author

Also, by [pep8] settings you're referring to in the tox.ini (https://github.com/GoogleCloudPlatform/gcloud-python/blob/master/tox.ini#L144). Switching it to [pycodestyle] produces a bunch of errors like it's not picking it up for some reason.

Might be a pycodestyle bug? I tried it before when I did the pep8->pycodestyle conversion and it broke then too.

@daspecster daspecster mentioned this pull request Jul 22, 2016
Merged
@daspecster

daspecster commented Jul 22, 2016

Copy link
Copy Markdown
Contributor Author

We can talk more here #2020

@tseaver

tseaver commented Jul 23, 2016 •
edited
Loading

Copy link
Copy Markdown
Contributor

That is a failure in pylint, not pycodestyle: it is trying to check docs/conf.pyscripts/verify_included_modules.py. We could just exclude that file from pylint.

daspecster added a commit to daspecster/google-cloud-python that referenced this pull request Jul 23, 2016
@daspecster
Revert googleapis#2019.
75aae3b
@daspecster daspecster mentioned this pull request Jul 23, 2016
Merged
@daspecster

daspecster commented Jul 23, 2016

Copy link
Copy Markdown
Contributor Author

@tseaver thanks! Here we go #2021.

This was referenced Aug 3, 2016
Closed
Merged
@daspecster daspecster deleted the fix-lint-sphinx-dep branch January 24, 2017 15:18
parthea pushed a commit that referenced this pull request Apr 1, 2026
@chelsea-lin
fix: read_csv fails when check file size for wildcard gcs files (#2019)
fca8f78
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@tseaver tseaver

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@daspecster @waprin @dhermes @tseaver @googlebot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.