Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Clarify handling of V2 'ReadRowsResponse' error cases#1915

Merged
tseaver merged 2 commits into
googleapis:bigtable-v2googleapis/google-cloud-python:bigtable-v2from
tseaver:bigtable-v2-readrowsresponse-error-casesCopy head branch name to clipboard
Jun 27, 2016
Merged

Clarify handling of V2 'ReadRowsResponse' error cases#1915
tseaver merged 2 commits into
googleapis:bigtable-v2googleapis/google-cloud-python:bigtable-v2from
tseaver:bigtable-v2-readrowsresponse-error-casesCopy head branch name to clipboard

Conversation

@tseaver

@tseaver tseaver commented Jun 27, 2016

Copy link
Copy Markdown
Contributor

Distinguish response-level errors from invalid chunks.

JSON testcases ending in an incomplete row should not raise errors.

For "invalid" JSON testcases, verify that completed, non-error rows match expected results.

Assert that the state is 'ROW_IN_PROGRESS', and check that the completed
rows match the expected results.
@tseaver tseaver added the api: bigtable Issues related to the Bigtable API. label Jun 27, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 27, 2016
Verify that completed, non-error rows match expected results after an
invalid chunk testcase.
@tseaver tseaver merged commit fcc3751 into googleapis:bigtable-v2 Jun 27, 2016
@tseaver tseaver deleted the bigtable-v2-readrowsresponse-error-cases branch June 27, 2016 16:07
parthea pushed a commit that referenced this pull request Mar 6, 2026
* add new presubmit for test purposes

* add additional sessions

* Update .kokoro/presubmit/presubmit-2.cfg

* Update .kokoro/presubmit/presubmit-2.cfg

* added timer to nox sessions

* Update .kokoro/presubmit/presubmit-2.cfg

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* removes references to most environment variables

* testing the use of base names for the nox sessions

* removes references to unneeded linting and typing env variables

* change file name and update env_vars in presubmit-2

* remove timed decorators

* revert several files

* Update noxfile.py

* remove test, remove unneeded vars, etc

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.