fix: remove usage of typing_extensions where possible#17358
Draft
parthea wants to merge 4 commits into
maingoogleapis/google-cloud-python:mainfrom
remove-typing-extensionsgoogleapis/google-cloud-python:remove-typing-extensionsCopy head branch name to clipboard
Draft
fix: remove usage of typing_extensions where possible#17358parthea wants to merge 4 commits intomaingoogleapis/google-cloud-python:mainfrom remove-typing-extensionsgoogleapis/google-cloud-python:remove-typing-extensionsCopy head branch name to clipboard
parthea wants to merge 4 commits into
maingoogleapis/google-cloud-python:mainfrom
remove-typing-extensionsgoogleapis/google-cloud-python:remove-typing-extensionsCopy head branch name to clipboard
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request attempts to simplify type hinting imports by replacing conditional imports from typing_extensions with direct imports from typing and types (such as TypeGuard, Self, ParamSpec, TypeAlias, Concatenate, and UnionType). However, because several of the modified packages still support Python 3.8 or 3.9, these direct imports will cause runtime ImportErrors or type-checking failures on older Python versions. The feedback recommends restoring the conditional imports based on sys.version_info to preserve backward compatibility.
59b8df4 to
b4733cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17244