Merged
tests: resolve failure related to unpacking dictionary for protobuf messages#17273
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces two new protocol buffer fragment files for testing: locations.proto, which defines a standard Locations service with its request and response messages, and test_protobuf_type.proto, which defines a MockLocationService utilizing the types from locations.proto. There are no review comments, so I have no feedback to provide.
ohmayr
approved these changes
May 27, 2026
ohmayr
approved these changes
May 27, 2026
chalmerlowe
pushed a commit
to googleapis/librarian
that referenced
this pull request
May 28, 2026
…6183) The version of gapic-generator in the embedded librarian.yaml (used by librarian install) is updated to v1.34.1. This will unblock bigtable generation (b/503326310) which needs the fix from googleapis/google-cloud-python#17260 which is included in v1.34.0. v1.34.0 could not be used due to a regression. The regression was fixed in googleapis/google-cloud-python#17273 (hence why we need gapic-generator v1.34.1 now). See follow up issue to improve our testing strategy in #6182 Signed-off-by: Anthonios Partheniou <partheniou@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves the following failure in #17245 (build log)
To resolve the issue, this PR adds
**to unpack fields as keyword arguments, maintaining compatibility with both proto-plus and pure protobuf messages.