Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

fix(spanner): drop support for Python 3.9#17003

Closed
sakthivelmanii wants to merge 2 commits into
maingoogleapis/google-cloud-python:mainfrom
drop-py39-spannergoogleapis/google-cloud-python:drop-py39-spannerCopy head branch name to clipboard
Closed

fix(spanner): drop support for Python 3.9#17003
sakthivelmanii wants to merge 2 commits into
maingoogleapis/google-cloud-python:mainfrom
drop-py39-spannergoogleapis/google-cloud-python:drop-py39-spannerCopy head branch name to clipboard

Conversation

@sakthivelmanii

@sakthivelmanii sakthivelmanii commented May 8, 2026

Copy link
Copy Markdown
Contributor

Python 3.9 is EOL and missing from the Kokoro test image, causing nightly failures.

  • Remove "3.9" from noxfile.py ALL_PYTHON and sessions
  • Remove "3.9" from setup.py classifiers and update python_requires to >=3.10

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

Python 3.9 is EOL and missing from the Kokoro test image, causing nightly failures.

- Remove "3.9" from noxfile.py ALL_PYTHON and sessions
- Remove "3.9" from setup.py classifiers and update python_requires to >=3.10

BREAKING CHANGE: Python 3.9 is no longer supported. Minimum supported version is now 3.10.
@sakthivelmanii sakthivelmanii requested a review from a team as a code owner May 8, 2026 07:17

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request drops support for Python 3.9 in the google-cloud-spanner package. The changes involve removing Python 3.9 from the Nox configuration and updating setup.py to require Python 3.10 or higher. I have no feedback to provide as there were no review comments.

@parthea parthea left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The files in this PR are automatically generated and patched using post processing here :

https://github.com/googleapis/google-cloud-python/blob/main/.librarian/generator-input/client-post-processing/spanner-integration.yaml

The changes to drop 3.9 in all packages which have files generated by gapic-generator will be rolled out next week.

Please can you file a bug with the specific presubmits that are failing today? Checks in the last release PR succeeded: #16964

@parthea parthea closed this May 8, 2026
@sakthivelmanii

Copy link
Copy Markdown
Contributor Author

@parthea

parthea commented May 11, 2026

Copy link
Copy Markdown
Contributor

This will be addressed in #17017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.