chore(proto-plus): update Python version and clean up enums.py#16912
Merged
chalmerlowe merged 5 commits intoMay 4, 2026
maingoogleapis/google-cloud-python:mainfrom
chore/update-python-version-proto-plusgoogleapis/google-cloud-python:chore/update-python-version-proto-plusCopy head branch name to clipboard
Merged
chore(proto-plus): update Python version and clean up enums.py#16912chalmerlowe merged 5 commits intomaingoogleapis/google-cloud-python:mainfrom chore/update-python-version-proto-plusgoogleapis/google-cloud-python:chore/update-python-version-proto-plusCopy head branch name to clipboard
chalmerlowe merged 5 commits into
maingoogleapis/google-cloud-python:mainfrom
chore/update-python-version-proto-plusgoogleapis/google-cloud-python:chore/update-python-version-proto-plusCopy head branch name to clipboard
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request replaces a descriptive comment in packages/proto-plus/proto/enums.py with a TODO referencing Issue #16911 regarding the use of the ignore attribute. I have no feedback to provide as there are no review comments.
Contributor
|
Switching to draft until presubmits are green |
chalmerlowe
commented
May 4, 2026
parthea
approved these changes
May 4, 2026
zhixiangli
pushed a commit
to zhixiangli/google-cloud-python
that referenced
this pull request
May 6, 2026
…eapis#16912) This PR updates `proto-plus` to establish Python 3.10 as the minimum supported version, dropping support for Python 3.9 and below. ### Changes * Configuration: Updated `pyproject.toml` and `noxfile.py` to require Python 3.10+ and remove references to Python 3.9. * Code: Refactored `repeated.py` to use the walrus operator (PEP 572). Documentation: Updated a traceback example in `docs/fields.rst` to reference Python 3.10. * Cleanup: Replaced a stale comment regarding Python 3.7 features in proto/enums.py with a tracked TODO referencing Issue googleapis#16911. > [!note] > Also includes a conditional in the `run_single_test.sh` file to manage the chicken OR the egg problem of managing failing tests when a `unit-3.9` nox session is not present. Because we are migrating handwritten libs one at a time, we are in a transition period were we must still test for 3.9 in libraries that still support it but cannot have a failing presubmit in libraries that don't support it. ### Blocking - [x] This PR is blocked by PR googleapis#16910
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates
proto-plusto establish Python 3.10 as the minimum supported version, dropping support for Python 3.9 and below.Changes
pyproject.tomlandnoxfile.pyto require Python 3.10+ and remove references to Python 3.9.repeated.pyto use the walrus operator (PEP 572).Documentation: Updated a traceback example in
docs/fields.rstto reference Python 3.10.Note
Also includes a conditional in the
run_single_test.shfile to manage the chicken OR the egg problem of managing failing tests when aunit-3.9nox session is not present. Because we are migrating handwritten libs one at a time, we are in a transition period were we must still test for 3.9 in libraries that still support it but cannot have a failing presubmit in libraries that don't support it.Blocking