Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Beginning of HappyBase batch module.#1515

Merged
dhermes merged 1 commit into
googleapis:mastergoogleapis/google-cloud-python:masterfrom
dhermes:begin-happybase-batchdhermes/google-cloud-python:begin-happybase-batchCopy head branch name to clipboard
Feb 23, 2016
Merged

Beginning of HappyBase batch module.#1515
dhermes merged 1 commit into
googleapis:mastergoogleapis/google-cloud-python:masterfrom
dhermes:begin-happybase-batchdhermes/google-cloud-python:begin-happybase-batchCopy head branch name to clipboard

Conversation

@dhermes

@dhermes dhermes commented Feb 21, 2016

Copy link
Copy Markdown
Contributor

@dhermes dhermes added the api: bigtable Issues related to the Bigtable API. label Feb 21, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 21, 2016
@tseaver tseaver mentioned this pull request Feb 22, 2016
Merged
@dhermes dhermes assigned theacodes and unassigned tseaver Feb 22, 2016
@theacodes

theacodes commented Feb 23, 2016

Copy link
Copy Markdown
Contributor

LGTM with minor readability nit.

(as an aside, I really hate unittest2's testing style)

theacodes
theacodes reviewed Feb 23, 2016
View reviewed changes
Comment thread gcloud/bigtable/happybase/batch.py
self._batch_size = batch_size
# Timestamp is in milliseconds, convert to microseconds.
self._timestamp = self._delete_range = None
if timestamp is not None:

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes

dhermes commented Feb 23, 2016

Copy link
Copy Markdown
Contributor Author

@jonparrott unittest2 is just a back-port of unittest, so there is no testing style to speak of. We do things guided by some notes from @tseaver.

@dhermes dhermes force-pushed the begin-happybase-batch branch from faf442d to bfc56f2 Compare February 23, 2016 20:25
dhermes added a commit that referenced this pull request Feb 23, 2016
@dhermes
Merge pull request #1515 from dhermes/begin-happybase-batch
115263b 
Beginning of HappyBase batch module.
@dhermes dhermes merged commit 115263b into googleapis:master Feb 23, 2016
@dhermes dhermes deleted the begin-happybase-batch branch February 23, 2016 20:29
@theacodes theacodes mentioned this pull request Mar 4, 2016
Merged
parthea pushed a commit that referenced this pull request Nov 26, 2025
@BigTailWolf
chore: update token (#1515)
6d5ae70
parthea pushed a commit that referenced this pull request Mar 2, 2026
@ohmayr
chore(librarian): onboard to librarian (#1515)
abdfd72
parthea pushed a commit that referenced this pull request Apr 1, 2026
@TrevorBergeron
chore: Ignore mypy false positive (#1515)
35b05fa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@theacodes theacodes

Labels

api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dhermes @theacodes @tseaver @googlebot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.