Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Add bigtable generated files#1152

Merged
dhermes merged 4 commits into
googleapis:mastergoogleapis/google-cloud-python:masterfrom
dhermes:add-bigtable-generated-filesdhermes/google-cloud-python:add-bigtable-generated-filesCopy head branch name to clipboard
Sep 28, 2015
Merged

Add bigtable generated files#1152
dhermes merged 4 commits into
googleapis:mastergoogleapis/google-cloud-python:masterfrom
dhermes:add-bigtable-generated-filesdhermes/google-cloud-python:add-bigtable-generated-filesCopy head branch name to clipboard

Conversation

@dhermes

@dhermes dhermes commented Sep 24, 2015

Copy link
Copy Markdown
Contributor

@tseaver These are generated with

https://github.com/dhermes/gcloud-python-bigtable/blob/7c88583a4f772701228c2c94c32a847670fe6a52/Makefile

I had to modify

https://github.com/dhermes/gcloud-python-bigtable/blob/7c88583a4f772701228c2c94c32a847670fe6a52/scripts/rewrite_imports.py

so that it rewrote imports as gcloud.bigtable instead of gcloud_bigtable.

Should I try to port the Makefile over as well? The reason I hesitate is because it requires having a valid gRPC install.

@dhermes
Adding Bigtable generated *pb2 files.
e720109 
Many auxiliary files (i.e. not part of the Bigtable service
definitions) are required.
@dhermes
Adding config changes to ignore Bigtable generated files.
1a6e4da
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 24, 2015
@dhermes dhermes mentioned this pull request Sep 24, 2015
Merged
@tseaver

tseaver commented Sep 24, 2015

Copy link
Copy Markdown
Contributor

I don't think there is much to review here: should we maybe be reviewing the generator first?

@dhermes

dhermes commented Sep 24, 2015

Copy link
Copy Markdown
Contributor Author

Sure. That is contingent on whether we should add it to the repo. A Makefile is certainly not platform independent, so I hesitate a little bit. (NOTE: I want to do a similar thing with #594 but the gRPC plugin for protoc makes some imports that we can't use. I need to be less dumb using namespace packages though and maybe we could avoid import rewrites.)

@tseaver

tseaver commented Sep 24, 2015

Copy link
Copy Markdown
Contributor

Should we be checking in the .proto files?

@dhermes

dhermes commented Sep 24, 2015

Copy link
Copy Markdown
Contributor Author

Yeah good call!

@tseaver

tseaver commented Sep 24, 2015

Copy link
Copy Markdown
Contributor

I think checking in the Makefile too is worthwhile: even if it is Unix/Linux/Ubuntu-dependent, it "documents" how the generated files are created, allowing users to figure out how to replicate on their own systems.

@dhermes

dhermes commented Sep 24, 2015

Copy link
Copy Markdown
Contributor Author

I just added the .proto files. I'll bring in the Makefile too and we can discuss once it's in.

Do you want me to re-arrange the commits to make it more clear what's going in?

@tseaver

tseaver commented Sep 24, 2015

Copy link
Copy Markdown
Contributor

Commit order doesn't really matter to me -- I'm going to look primarily at the Makefile and one each of the .proto and _pb2.py files. If you think it is cleaner to rebase down to a single commit, that would be fine.

@tseaver

tseaver commented Sep 24, 2015

Copy link
Copy Markdown
Contributor

When the Makefile comes in, will I be able to regenerate from it (assuming protoc is on the path)?

@dhermes

dhermes commented Sep 24, 2015

Copy link
Copy Markdown
Contributor Author

Not unless you also have the grpc_python_plugin installed. And you may need the latest and greatest version of protoc to support proto3 (was proto2 for awhile). I'm not sure about that one though.

@dhermes

dhermes commented Sep 24, 2015

Copy link
Copy Markdown
Contributor Author

@tseaver PTAL (I added the Makefile)

@tseaver

tseaver commented Sep 28, 2015

Copy link
Copy Markdown
Contributor

LGTM -- I wish we had directions (in CONTRIBUTING.rst, maybe) about the environment needed to be able to recreate the generated files.

dhermes added a commit that referenced this pull request Sep 28, 2015
@dhermes
Merge pull request #1152 from dhermes/add-bigtable-generated-files
7c151af 
Add bigtable generated files
@dhermes dhermes merged commit 7c151af into googleapis:master Sep 28, 2015
@dhermes dhermes deleted the add-bigtable-generated-files branch September 28, 2015 18:48
@dhermes

dhermes commented Sep 28, 2015

Copy link
Copy Markdown
Contributor Author

Take a look through

https://github.com/dhermes/gcloud-python-bigtable/blob/master/README.md
https://github.com/dhermes/gcloud-python-bigtable/blob/master/CONTRIBUTING.md

and let me know what you'd like to be brought over.

Unfortunately (or maybe it's fortunate?) the gRPC install story is ever-evolving so the docs will be out-of-date pretty soon.

@dhermes dhermes mentioned this pull request Sep 30, 2015
Merged
parthea pushed a commit that referenced this pull request Nov 22, 2025
@release-please
chore(main): release 2.32.0 (#1152)
a44605f 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 26, 2025
@clundin25
refactor: ECP Config schema update. Googlers see go/enterpise-cert-co…
7838de2 
…nfig (#1152)

* refactor: ECP Config schema update. Googlers see go/enterpise-cert-config
parthea pushed a commit that referenced this pull request Mar 2, 2026
@release-please
chore(main): release 2.32.0 (#1152)
eaef6d5 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Mar 9, 2026
@harshachinta
feat(spanner): add support for txn changstream exclusion (#1152)
b255321 
* feat(spanner): add support for txn changstream exclusion

* feat(spanner): add tests for txn change streams exclusion

* chore(spanner): lint fix

* feat(spanner): add docs

* feat(spanner): add test for ILB with change stream exclusion

* feat(spanner): update default value and add optional
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dhermes @tseaver @googlebot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.