Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

perf(bigquery): remove redundant array deepcopy#10139

Closed
grooveygr wants to merge 2 commits into
googleapis:mastergoogleapis/google-cloud-python:masterfrom
grooveygr:mastergrooveygr/google-cloud-python:masterCopy head branch name to clipboard
Closed

perf(bigquery): remove redundant array deepcopy#10139
grooveygr wants to merge 2 commits into
googleapis:mastergoogleapis/google-cloud-python:masterfrom
grooveygr:mastergrooveygr/google-cloud-python:masterCopy head branch name to clipboard

Conversation

@grooveygr

@grooveygr grooveygr commented Jan 15, 2020

Copy link
Copy Markdown

Deepcopy can be a very costly operation when considering large arrays with complex nested objects.
Refactor helpers to allow recursive conversion without copying arrays.

Fixes #10138 🦕

@grooveygr
perf(bigquery): remove redundant array deepcopy
dd57d4f 
deepcopy can be a very costly operation when considering large arrays with complex nested objects.
refactor helpers to allow recursive conversion without copying arrays.
@grooveygr grooveygr requested a review from a team January 15, 2020 07:09
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 15, 2020
@IlyaFaer IlyaFaer added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 15, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 15, 2020
@plamut plamut added the api: bigquery Issues related to the BigQuery API. label Jan 15, 2020
@IlyaFaer IlyaFaer added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 16, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 16, 2020
@plamut plamut added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 3, 2020
@plamut

plamut commented Feb 3, 2020

Copy link
Copy Markdown
Contributor

Starting the repo split, please do not merge.

@plamut

plamut commented Feb 6, 2020

Copy link
Copy Markdown
Contributor

The repo split for BigQuery is done, please open the PR in the new repo, thanks!

https://github.com/googleapis/python-bigquery

@plamut

plamut commented Feb 10, 2020

Copy link
Copy Markdown
Contributor

Superseded by googleapis/python-bigquery#26

@plamut plamut closed this Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@grooveygr @plamut @googlebot @IlyaFaer @yoshi-kokoro
Morty Proxy This is a proxified and sanitized view of the page, visit original site.