Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Make errors more verbose in system test failures #2414

Copy link
Copy link

Description

@dhermes
Issue body actions

This way we can capture the entire state of the error to determine.

Also worth doing: Including the entire error response in the returned object. This way, in cases like the 503 error in #2093 where the JSON payload isn't what our code expects. Things still work fine.

In that case, the 503 payload is

{
  "error": {
    "code": 503,
    "message": "Write collision, please retry.",
    "status": "UNAVAILABLE",
    "details": [
      {
        "@type": "type.googleapis.com/google.rpc.RetryInfo",
        "retryDelay": "1.000s"
      }
    ]
  }
}

This seems to be a JSON version of the google.rpc.status.Status protobuf message type, with an extra status field that looks like a google.rpc.code.Code.

Our error-payload-parsing code makes the assumption that the errors come in the form:

{
  "error": {
    "message": "...",
    "errors": [
        "..."
    ]
  },
  "...": "..."
}
Reactions are currently unavailable

Metadata

Metadata

Labels

priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.testing

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

    Morty Proxy This is a proxified and sanitized view of the page, visit original site.