Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Remove setup_request_id fallback in generated packages when google-api-core >= 2.26.0 #17813

Copy link
Copy link

Description

@hebaalazzeh
Issue body actions

Overview

During the GAPIC request-id deduplication effort (centralizing request ID generation into google.api_core.gapic_v1.requests.setup_request_id), a backward-compatibility fallback module (_compat.py) was introduced in generated client packages to maintain compatibility with older versions of google-api-core.

Once google-api-core >= 2.26.0 (or the version containing setup_request_id) becomes the minimum required version across all generated client packages, this fallback can be removed.

Tasks

  • Remove _compat.py.j2 template from gapic-generator-python.
  • Update client.py.j2 and async_client.py.j2 to import setup_request_id directly from google.api_core.gapic_v1.requests.
  • Remove _compat.py files from tests/integration/goldens/.
Reactions are currently unavailable

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

Morty Proxy This is a proxified and sanitized view of the page, visit original site.