Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Resolve flaky firestore tests #17428

Copy link
Copy link

Description

@ohmayr
Issue body actions

The Firestore watch/listener system tests (test_watch_document, test_watch_collection, test_watch_query, and test_watch_query_order) currently rely on hardcoded sleep(0.2) delays and polling loops to coordinate snapshot updates.

These delays are fragile, highly susceptible to environmental latency/slow networks, and can cause test flakiness. We should investigate replacing these arbitrary polling loops with a robust, event-driven synchronization mechanism (e.g., using threading.Event or callback signals) that yields immediately upon receiving the expected snaps.

Reactions are currently unavailable

Metadata

Metadata

Assignees

Labels

triage meI really want to be triaged.I really want to be triaged.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

    Morty Proxy This is a proxified and sanitized view of the page, visit original site.