Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit f5b392e

Browse filesBrowse files
chalmerlowechalmerlowe
authored
fix(sqlalchemy-spanner): Drop support for Python 3.8 and 3.9 (#16913)
This PR updates `sqlalchemy-spanner` to establish Python 3.10 as the minimum supported version, dropping support for Python 3.9 and below. ### Changes * Configuration: Updated `setup.py` and `noxfile.py` to require Python 3.10+ and remove references to Python 3.7, 3.8, and 3.9. * Cleanup: Removed dead code in `noxfile.py` that was skipping Python 3.7. ### Blocking This PR is blocked by PR #16910
1 parent 6698861 commit f5b392e
Copy full SHA for f5b392e

2 files changed

+5-7Lines changed: 5 additions & 7 deletions

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎packages/sqlalchemy-spanner/noxfile.py‎

Copy file name to clipboardExpand all lines: packages/sqlalchemy-spanner/noxfile.py
+4-5Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -80,11 +80,10 @@ class = StreamHandler
8080
BLACK_VERSION = "black==23.7.0"
8181
ISORT_VERSION = "isort==5.11.0"
8282
BLACK_PATHS = ["google", "tests", "noxfile.py", "setup.py", "samples"]
83-
UNIT_TEST_PYTHON_VERSIONS = ["3.8", "3.9", "3.10", "3.11", "3.12", "3.13", "3.14"]
83+
UNIT_TEST_PYTHON_VERSIONS = ["3.10", "3.11", "3.12", "3.13", "3.14"]
8484
ALL_PYTHON = list(UNIT_TEST_PYTHON_VERSIONS)
85-
ALL_PYTHON.extend(["3.7"])
8685
SYSTEM_TEST_PYTHON_VERSIONS = ["3.12"]
87-
SYSTEM_COMPLIANCE_MIGRATION_TEST_PYTHON_VERSIONS = ["3.8", "3.12", "3.14"]
86+
SYSTEM_COMPLIANCE_MIGRATION_TEST_PYTHON_VERSIONS = ["3.12", "3.14"]
8887
DEFAULT_PYTHON_VERSION = "3.14"
8988
DEFAULT_PYTHON_VERSION_FOR_SQLALCHEMY_20 = "3.14"
9089

@@ -180,6 +179,8 @@ def compliance_test_14(session):
180179
"--asyncio-mode=auto",
181180
"tests/test_suite_14.py",
182181
*session.posargs,
182+
# Silence SQLAlchemy 2.0 transition warnings for this 1.4 compatibility session.
183+
env={"SQLALCHEMY_SILENCE_UBER_WARNING": "1"},
183184
)
184185

185186

@@ -318,8 +319,6 @@ def _migration_test(session):
318319
@nox.parametrize("test_type", ["unit", "mockserver"])
319320
def unit(session, test_type):
320321
"""Run unit tests."""
321-
if session.python in ("3.7",):
322-
session.skip("Python 3.7 is no longer supported")
323322

324323
if (
325324
test_type == "mockserver"
Collapse file

‎packages/sqlalchemy-spanner/setup.py‎

Copy file name to clipboardExpand all lines: packages/sqlalchemy-spanner/setup.py
+1-2Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,11 +58,10 @@
5858
author="Google LLC",
5959
author_email="googleapis-packages@google.com",
6060
license="Apache 2.0",
61+
python_requires=">=3.10",
6162
classifiers=[
6263
"Intended Audience :: Developers",
6364
"License :: OSI Approved :: Apache Software License",
64-
"Programming Language :: Python :: 3.8",
65-
"Programming Language :: Python :: 3.9",
6665
"Programming Language :: Python :: 3.10",
6766
"Programming Language :: Python :: 3.11",
6867
"Programming Language :: Python :: 3.12",

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.