Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Regenerate datastore client#4132

Closed
yoshi-automation wants to merge 1 commit into
mastergoogleapis/google-cloud-java:masterfrom
autosynth-datastoregoogleapis/google-cloud-java:autosynth-datastoreCopy head branch name to clipboard
Closed

Regenerate datastore client#4132
yoshi-automation wants to merge 1 commit into
mastergoogleapis/google-cloud-java:masterfrom
autosynth-datastoregoogleapis/google-cloud-java:autosynth-datastoreCopy head branch name to clipboard

Conversation

@yoshi-automation

Copy link
Copy Markdown
Contributor

This PR was generated using Autosynth. 🌈

Here's the log from Synthtool:

synthtool > You are running the synthesis script directly, this will be disabled in a future release of Synthtool. Please use python3 -m synthtool instead.
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
latest: Pulling from googleapis/artman
Digest: sha256:2f6b261ee7fe1aedf238991c93a20b3820de37a343d0cacf3e3e9555c2aaf2ea
Status: Image is up to date for googleapis/artman:latest
synthtool > Cloning googleapis.
synthtool > Running generator for google/datastore/artman_datastore.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java.
synthtool > Running java formatter on 96 files
synthtool > Running java formatter on 73 files
synthtool > Cleaned up 0 temporary directories.

@yoshi-automation yoshi-automation requested a review from a team November 30, 2018 08:39
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 30, 2018
@chingor13 chingor13 closed this Nov 30, 2018
chingor13 pushed a commit that referenced this pull request Mar 20, 2026
🤖 I have created a release *beep* *boop*
---


<details><summary>2.68.0</summary>

##
[2.68.0](googleapis/sdk-platform-java@v2.67.0...v2.68.0)
(2026-03-17)


### Features

* Add client request duration metric.
([#4132](googleapis/sdk-platform-java#4132))
([487650e](googleapis/sdk-platform-java@487650e))
* Add more attributes to golden signals metrics.
([#4135](googleapis/sdk-platform-java#4135))
([bc82dcb](googleapis/sdk-platform-java@bc82dcb))
* **gax-httpjson:** add HttpJsonErrorParser utility
([#4137](googleapis/sdk-platform-java#4137))
([6fe2446](googleapis/sdk-platform-java@6fe2446))
* **generator:** add extra allowed modules that will not be removed from
the monorepo if they are present
([#4124](googleapis/sdk-platform-java#4124))
([6a440da](googleapis/sdk-platform-java@6a440da))
* **o11y:** introduce `gcp.client.repo` and `gcp.client.artifact`
attributes
([#4120](googleapis/sdk-platform-java#4120))
([4954de5](googleapis/sdk-platform-java@4954de5))
* **o11y:** Introduce `rpc.system.name` and `rpc.method` in gRPC
([#4121](googleapis/sdk-platform-java#4121))
([3593c30](googleapis/sdk-platform-java@3593c30))
* **o11y:** introduce server.port attribute
([#4128](googleapis/sdk-platform-java#4128))
([1b10e02](googleapis/sdk-platform-java@1b10e02))


### Bug Fixes

* add null checks for ApiTracerFactory in ClientContext
([#4122](googleapis/sdk-platform-java#4122))
([ded1922](googleapis/sdk-platform-java@ded1922))
* Decrease log level for directpath warnings outside GCE
([#4139](googleapis/sdk-platform-java#4139))
([5151f34](googleapis/sdk-platform-java@5151f34))
* **gax-grpc:** add pick_first fallback to direct path service config
([#4143](googleapis/sdk-platform-java#4143))
([4934ad8](googleapis/sdk-platform-java@4934ad8))
* Populate method level attributes in metrics recording
([#4149](googleapis/sdk-platform-java#4149))
([69aabf8](googleapis/sdk-platform-java@69aabf8))
* suppress warnings in generated projects for non-idiomatic durations
([#4119](googleapis/sdk-platform-java#4119))
([8a0c565](googleapis/sdk-platform-java@8a0c565))
* Use ServiceName + MethodName as the regex for Otel
([#2543](googleapis/sdk-platform-java#2543))
([8196b8f](googleapis/sdk-platform-java@8196b8f))


### Documentation

* **hermetic_build:** fix config field name in readme
([#4130](googleapis/sdk-platform-java#4130))
([0d98c37](googleapis/sdk-platform-java@0d98c37))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
chingor13 pushed a commit that referenced this pull request Mar 24, 2026
This PR adds basic implementation for client request duration metric.

The following attributes are also added:

- gcp.client.artifact. Added as instrumentation scope name of the meter.
- rpc.response.status_code. Added as a String representation of
[StatusCode.Code](https://github.com/googleapis/sdk-platform-java/blob/1b10e02c3a07f70124304bc173987979dd781cdd/gax-java/gax/src/main/java/com/google/api/gax/rpc/StatusCode.java#L44).

The overall design follows `ApiTracer`/`ApiTracerFactory` pattern,
creates `GoldenSignalsMetricsTracer`/`GoldenSignalsMetricsTracerFactory`
that implement ApiTracer/ApiTracerFactory respectively.
`GoldenSignalsMetricsTracerFactory` is expected to be passed in during
client initialization. `GoldenSignalsMetricsTracer` tracks the lifecycle
of a request and calculates the duration of client requests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.