BIgtable: bug fix - Fix Reframer error handling#2920
Merged
pongad merged 2 commits intoFeb 21, 2018
googleapis:mastergoogleapis/google-cloud-java:masterfrom
igorbernstein2:99-bug-02-reframer-errorsigorbernstein2/google-cloud-java:99-bug-02-reframer-errorsCopy head branch name to clipboard
Merged
BIgtable: bug fix - Fix Reframer error handling#2920pongad merged 2 commits intogoogleapis:mastergoogleapis/google-cloud-java:masterfrom igorbernstein2:99-bug-02-reframer-errorsigorbernstein2/google-cloud-java:99-bug-02-reframer-errorsCopy head branch name to clipboard
pongad merged 2 commits into
googleapis:mastergoogleapis/google-cloud-java:masterfrom
igorbernstein2:99-bug-02-reframer-errorsigorbernstein2/google-cloud-java:99-bug-02-reframer-errorsCopy head branch name to clipboard
Conversation
pongad
reviewed
Feb 18, 2018
pongad
left a comment
Contributor
There was a problem hiding this comment.
Test seems to be failing. Might be related to the comment?
| try { | ||
| reframer.push(response); | ||
| } catch (Throwable t) { | ||
| if (error != null) { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
Author
|
Although this is superseded by #2925. Please merge this while that PR is being discussed |
chingor13
pushed a commit
that referenced
this pull request
Mar 24, 2026
chingor13
pushed a commit
that referenced
this pull request
Mar 24, 2026
🤖 I have created a release *beep* *boop* --- ## [6.60.1](https://togithub.com/googleapis/java-spanner/compare/v6.60.0...v6.60.1) (2024-02-23) ### Dependencies * Update dependency com.google.cloud:google-cloud-monitoring to v3.37.0 ([#2920](https://togithub.com/googleapis/java-spanner/issues/2920)) ([c2115a6](https://togithub.com/googleapis/java-spanner/commit/c2115a698b00f2dce810b7a48ad7b722d085200c)) * Update dependency org.graalvm.buildtools:native-maven-plugin to v0.10.0 ([#2861](https://togithub.com/googleapis/java-spanner/issues/2861)) ([d32adc3](https://togithub.com/googleapis/java-spanner/commit/d32adc3587f388464f3f5c5e42ecd94b9b49bb2f)) * Update dependency org.graalvm.buildtools:native-maven-plugin to v0.10.1 ([#2919](https://togithub.com/googleapis/java-spanner/issues/2919)) ([cbd6629](https://togithub.com/googleapis/java-spanner/commit/cbd66293b45aac7b6d3c6951af2fd1b3880839e9)) * Update dependency org.json:json to v20240205 ([#2913](https://togithub.com/googleapis/java-spanner/issues/2913)) ([98fa243](https://togithub.com/googleapis/java-spanner/commit/98fa243025b624b397a4589cca6d94934496d011)) * Update dependency org.junit.vintage:junit-vintage-engine to v5.10.2 ([#2868](https://togithub.com/googleapis/java-spanner/issues/2868)) ([030d281](https://togithub.com/googleapis/java-spanner/commit/030d281a120cfc56a628e19dd4cb01f986f283ab)) * Update opentelemetry.version to v1.35.0 ([#2902](https://togithub.com/googleapis/java-spanner/issues/2902)) ([f2cdf12](https://togithub.com/googleapis/java-spanner/commit/f2cdf126be9cd3fc1741a9cf2d29041d34a372a9)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure to cancel the upstream when the reframer throws an error