Bigtable: 03. Surface: SampleRowKeys#2857
Merged
garrettjonesgoogle merged 4 commits intoFeb 15, 2018
googleapis:mastergoogleapis/google-cloud-java:masterfrom
igorbernstein2:03-surface-sample-row-keysigorbernstein2/google-cloud-java:03-surface-sample-row-keysCopy head branch name to clipboard
Merged
Bigtable: 03. Surface: SampleRowKeys#2857garrettjonesgoogle merged 4 commits intogoogleapis:mastergoogleapis/google-cloud-java:masterfrom igorbernstein2:03-surface-sample-row-keysigorbernstein2/google-cloud-java:03-surface-sample-row-keysCopy head branch name to clipboard
garrettjonesgoogle merged 4 commits into
googleapis:mastergoogleapis/google-cloud-java:masterfrom
igorbernstein2:03-surface-sample-row-keysigorbernstein2/google-cloud-java:03-surface-sample-row-keysCopy head branch name to clipboard
Conversation
fe905c1 to
72c73b6
Compare
Contributor
Author
|
rebased |
Contributor
Author
|
PTAL after #2861. This is ready for review |
Contributor
|
@igorbernstein2 Looks like we need another rebase? |
Adds the surface to wrap SampleRowKeys RPC. The surface: - hides the fact that the RPC is streaming - wraps the request as a simple string table id - wraps the response in KeyOffset
30d5dbe to
79d3457
Compare
Contributor
Author
|
rebased |
pongad
reviewed
Feb 15, 2018
| * should therefore not make any assumptions about the row key structure that are specific to | ||
| * their use case. | ||
| */ | ||
| public abstract ByteString geyKey(); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| /** | ||
| * Convenience method to asynchronously return a sample of row keys in the table. The returned row | ||
| * keys will delimit contiguous sections of the table of approximately equal size, which can be | ||
| * used to break up the data for distributed tasks like mapreduces. The returned callable object |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| /** | ||
| * A row key value that is returned as part of the response of | ||
| * {@link com.google.cloud.bigtable.data.v2.BigtableDataClient#sampleRowKeys(String)}. The key | ||
| * represents end boundary of one of the contiguous section in a list of approximately equal sized |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
Author
|
Fixed docs. Please merge when ready |
Contributor
Author
|
Thank you! |
chingor13
pushed a commit
that referenced
this pull request
Feb 20, 2026
…ng to v1.47.0 (#2857) Co-authored-by: Phong Chuong <147636638+PhongChuong@users.noreply.github.com>
chingor13
pushed a commit
that referenced
this pull request
Mar 24, 2026
* test: disable proto column tests * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
rahul2393
pushed a commit
to akash329d/google-cloud-java
that referenced
this pull request
May 21, 2026
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/java-bigtable/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) - [ ] Rollback plan is reviewed and LGTMed - [ ] All new data plane features have a completed end to end testing plan Fixes #<issue_number_goes_here> ☕️ If you write sample code, please follow the [samples format]( https://togithub.com/GoogleCloudPlatform/java-docs-samples/blob/main/SAMPLE_FORMAT.md).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the surface to wrap SampleRowKeys RPC. The surface:
This has been reviewed Kevin. However some things have changed since the original review: