bigquery: proper handle options to Job.getQueryResults#2713
Merged
pongad merged 2 commits intoDec 20, 2017
googleapis:bq-perfgoogleapis/google-cloud-java:bq-perffrom
pongad:bq-optCopy head branch name to clipboard
Merged
bigquery: proper handle options to Job.getQueryResults#2713pongad merged 2 commits intogoogleapis:bq-perfgoogleapis/google-cloud-java:bq-perffrom pongad:bq-optCopy head branch name to clipboard
pongad merged 2 commits into
googleapis:bq-perfgoogleapis/google-cloud-java:bq-perffrom
pongad:bq-optCopy head branch name to clipboard
Conversation
pongad
commented
Dec 15, 2017
|
|
||
| List<QueryResultsOption> waitOptions = new ArrayList<>(); | ||
| waitOptions.add(QueryResultsOption.pageSize(0L)); | ||
| List<TableDataListOption> listOptions = new ArrayList<>(); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
tswast
reviewed
Dec 15, 2017
|
|
||
| List<QueryResultsOption> waitOptions = new ArrayList<>(); | ||
| waitOptions.add(QueryResultsOption.pageSize(0L)); | ||
| List<TableDataListOption> listOptions = new ArrayList<>(); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| } | ||
| } | ||
| if (!hasWaitTime) { | ||
| waitOptions.add(QueryResultsOption.maxWaitTime(Duration.ofMinutes(1).toMillis())); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
jba
approved these changes
Dec 19, 2017
chingor13
pushed a commit
that referenced
this pull request
Feb 20, 2026
#2713) * chore: Update generation configuration at Sat Oct 12 02:22:47 UTC 2024 * chore: generate libraries at Sat Oct 12 02:23:08 UTC 2024 * chore: Update generation configuration at Sun Oct 13 02:27:02 UTC 2024
chingor13
pushed a commit
that referenced
this pull request
Mar 24, 2026
In this PR: - Remove test output directory.
chingor13
pushed a commit
that referenced
this pull request
Mar 30, 2026
#2713) Co-authored-by: Joe Wang <joewa@google.com>
meltsufin
pushed a commit
that referenced
this pull request
Apr 29, 2026
#2713) * chore: Update generation configuration at Tue Mar 24 03:02:27 UTC 2026 * chore: Update generation configuration at Wed Mar 25 03:04:37 UTC 2026 * chore: Update generation configuration at Thu Mar 26 03:06:35 UTC 2026 * chore: generate libraries at Thu Mar 26 03:07:04 UTC 2026 * chore: Update generation configuration at Fri Mar 27 03:06:58 UTC 2026 * chore: Update generation configuration at Sat Mar 28 03:03:59 UTC 2026 * chore: generate libraries at Sat Mar 28 03:04:25 UTC 2026 * chore: Update generation configuration at Tue Mar 31 03:06:58 UTC 2026 * chore: Update generation configuration at Wed Apr 1 03:06:55 UTC 2026 * chore: Update generation configuration at Thu Apr 2 03:06:32 UTC 2026 * chore: Update generation configuration at Fri Apr 3 03:06:35 UTC 2026 * chore: Update generation configuration at Tue Apr 7 03:06:43 UTC 2026 * chore: generate libraries at Tue Apr 7 03:07:16 UTC 2026 * chore: Update generation configuration at Wed Apr 8 03:06:45 UTC 2026 * chore: Update generation configuration at Thu Apr 9 03:06:29 UTC 2026 * chore: Update generation configuration at Fri Apr 10 03:07:38 UTC 2026 * chore: Update generation configuration at Sat Apr 11 03:05:07 UTC 2026 * chore: Update generation configuration at Mon Apr 13 03:08:33 UTC 2026 * chore: Update generation configuration at Tue Apr 14 03:07:21 UTC 2026 * build: use correct action version * chore: generate libraries at Tue Apr 14 14:49:54 UTC 2026 * deps: correct graalvm image version * chore: generate libraries at Tue Apr 14 17:04:16 UTC 2026 * chore: update generator version to 2.71.0 * chore: generate libraries at Tue Apr 14 17:10:27 UTC 2026 --------- Co-authored-by: Diego Marquez <diegomarquezp@google.com>
meltsufin
pushed a commit
that referenced
this pull request
May 1, 2026
#2713) * chore: Update generation configuration at Tue Mar 24 03:02:27 UTC 2026 * chore: Update generation configuration at Wed Mar 25 03:04:37 UTC 2026 * chore: Update generation configuration at Thu Mar 26 03:06:35 UTC 2026 * chore: generate libraries at Thu Mar 26 03:07:04 UTC 2026 * chore: Update generation configuration at Fri Mar 27 03:06:58 UTC 2026 * chore: Update generation configuration at Sat Mar 28 03:03:59 UTC 2026 * chore: generate libraries at Sat Mar 28 03:04:25 UTC 2026 * chore: Update generation configuration at Tue Mar 31 03:06:58 UTC 2026 * chore: Update generation configuration at Wed Apr 1 03:06:55 UTC 2026 * chore: Update generation configuration at Thu Apr 2 03:06:32 UTC 2026 * chore: Update generation configuration at Fri Apr 3 03:06:35 UTC 2026 * chore: Update generation configuration at Tue Apr 7 03:06:43 UTC 2026 * chore: generate libraries at Tue Apr 7 03:07:16 UTC 2026 * chore: Update generation configuration at Wed Apr 8 03:06:45 UTC 2026 * chore: Update generation configuration at Thu Apr 9 03:06:29 UTC 2026 * chore: Update generation configuration at Fri Apr 10 03:07:38 UTC 2026 * chore: Update generation configuration at Sat Apr 11 03:05:07 UTC 2026 * chore: Update generation configuration at Mon Apr 13 03:08:33 UTC 2026 * chore: Update generation configuration at Tue Apr 14 03:07:21 UTC 2026 * build: use correct action version * chore: generate libraries at Tue Apr 14 14:49:54 UTC 2026 * deps: correct graalvm image version * chore: generate libraries at Tue Apr 14 17:04:16 UTC 2026 * chore: update generator version to 2.71.0 * chore: generate libraries at Tue Apr 14 17:10:27 UTC 2026 --------- Co-authored-by: Diego Marquez <diegomarquezp@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.