Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

bigquery: allow schema-ful data listing#2697

Merged
pongad merged 5 commits into
googleapis:bq-perfgoogleapis/google-cloud-java:bq-perffrom
pongad:bq-table-resCopy head branch name to clipboard
Dec 14, 2017
Merged

bigquery: allow schema-ful data listing#2697
pongad merged 5 commits into
googleapis:bq-perfgoogleapis/google-cloud-java:bq-perffrom
pongad:bq-table-resCopy head branch name to clipboard

Conversation

@pongad

@pongad pongad commented Dec 12, 2017

Copy link
Copy Markdown
Contributor

listTableData and query now use the same classes.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 12, 2017
@tswast

tswast commented Dec 12, 2017

Copy link
Copy Markdown
Contributor

Looks like it's missing an update to the integration tests.

[ERROR] /home/travis/build/GoogleCloudPlatform/google-cloud-java/google-cloud-examples/src/test/java/com/google/cloud/examples/bigquery/snippets/ITBigQuerySnippets.java:[39,33] cannot find symbol

[ERROR]   symbol:   class QueryResult
[ERROR]   location: package com.google.cloud.bigquery

tswast
tswast reviewed Dec 12, 2017
View reviewed changes
Comment thread google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/BigQueryImpl.java
public Page<FieldValueList> listTableData(TableId tableId, TableDataListOption... options) {
return listTableData(tableId, getOptions(), optionMap(options));
public TableResult listTableData(TableId tableId, TableDataListOption... options) {
return listTableData(tableId, null, options);

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@pongad

pongad commented Dec 13, 2017

Copy link
Copy Markdown
Contributor Author

Build failure fixed now. Sorry, I keep missing them.

tswast
tswast approved these changes Dec 13, 2017
View reviewed changes
Comment thread google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/BigQueryImpl.java
public Page<FieldValueList> listTableData(TableId tableId, TableDataListOption... options) {
return listTableData(tableId, getOptions(), optionMap(options));
public TableResult listTableData(TableId tableId, TableDataListOption... options) {
return listTableData(tableId, null, options);

This comment was marked as spam.

Sign in to view

@pongad pongad merged commit 8ac24ed into googleapis:bq-perf Dec 14, 2017
@pongad pongad deleted the bq-table-res branch December 14, 2017 00:05
chingor13 pushed a commit that referenced this pull request Mar 24, 2026
@lqiu96
fix: Log HttpJson's async thread pool core size (#2697)
31038d1 
Fixes googleapis/sdk-platform-java#2680
chingor13 pushed a commit that referenced this pull request Mar 24, 2026
@release-please
chore(main): release 2.40.0 (#2679)
32ebbe1 
🤖 I have created a release *beep* *boop*
---


<details><summary>2.40.0</summary>

##
[2.40.0](googleapis/sdk-platform-java@v2.39.0...v2.40.0)
(2024-05-02)


### Features

* [common-protos] add `Weight` to common types for Shopping APIs to be
used for accounts bundle
([#2699](googleapis/sdk-platform-java#2699))
([90a28ef](googleapis/sdk-platform-java@90a28ef))
* add a CLI tool to validate generation configuration
([#2691](googleapis/sdk-platform-java#2691))
([f52f8cc](googleapis/sdk-platform-java@f52f8cc))
* Parser to consume the api-versioning value from proto
([#2630](googleapis/sdk-platform-java#2630))
([c112b37](googleapis/sdk-platform-java@c112b37))
* Update Gapic generator and Gax to emit api-versioning via header
([#2671](googleapis/sdk-platform-java#2671))
([cb5ada0](googleapis/sdk-platform-java@cb5ada0))


### Bug Fixes

* change folder prefix for adding headers
([#2688](googleapis/sdk-platform-java#2688))
([ab5ba1d](googleapis/sdk-platform-java@ab5ba1d))
* Log HttpJson's async thread pool core size
([#2697](googleapis/sdk-platform-java#2697))
([31038d1](googleapis/sdk-platform-java@31038d1))
* replace `cfg = "host"` with `cfg = "exec"`
([#2637](googleapis/sdk-platform-java#2637))
([fd12e0f](googleapis/sdk-platform-java@fd12e0f))
* Return resolved endpoint from StubSettings' Builder
([#2715](googleapis/sdk-platform-java#2715))
([6139a73](googleapis/sdk-platform-java@6139a73))


### Dependencies

* Make opentelemetry-api an optional dependency.
([#2681](googleapis/sdk-platform-java#2681))
([2239c8c](googleapis/sdk-platform-java@2239c8c))
* update dependency absl-py to v2.1.0
([#2659](googleapis/sdk-platform-java#2659))
([b2b7738](googleapis/sdk-platform-java@b2b7738))
* update dependency gitpython to v3.1.43
([#2656](googleapis/sdk-platform-java#2656))
([6d273ad](googleapis/sdk-platform-java@6d273ad))
* update dependency lxml to v5.2.1
([#2661](googleapis/sdk-platform-java#2661))
([7a34168](googleapis/sdk-platform-java@7a34168))
* update dependency net.bytebuddy:byte-buddy to v1.14.14
([#2703](googleapis/sdk-platform-java#2703))
([72b0441](googleapis/sdk-platform-java@72b0441))
* update dependency typing to v3.10.0.0
([#2663](googleapis/sdk-platform-java#2663))
([4c64e98](googleapis/sdk-platform-java@4c64e98))
* update gapic-showcase to v0.33.0
([#2653](googleapis/sdk-platform-java#2653))
([5c12155](googleapis/sdk-platform-java@5c12155))


### Documentation

* Add contributing guidelines to PR and issue templates
([#2682](googleapis/sdk-platform-java#2682))
([82f5ce8](googleapis/sdk-platform-java@82f5ce8))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
rahul2393 pushed a commit to akash329d/google-cloud-java that referenced this pull request May 21, 2026
@renovate-bot
deps: update shared dependencies (googleapis#2697)
e6fb44b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tswast tswast tswast approved these changes
@garrettjonesgoogle garrettjonesgoogle Awaiting requested review from garrettjonesgoogle

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pongad @tswast @googlebot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.