Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Regenerating clients with surface cleanup#2598

Merged
garrettjonesgoogle merged 1 commit into
googleapis:mastergoogleapis/google-cloud-java:masterfrom
garrettjonesgoogle:mastergarrettjonesgoogle/gcloud-java:masterCopy head branch name to clipboard
Nov 8, 2017
Merged

Regenerating clients with surface cleanup#2598
garrettjonesgoogle merged 1 commit into
googleapis:mastergoogleapis/google-cloud-java:masterfrom
garrettjonesgoogle:mastergarrettjonesgoogle/gcloud-java:masterCopy head branch name to clipboard

Conversation

@garrettjonesgoogle

Copy link
Copy Markdown
Contributor

This is a copy of googleapis/api-client-staging#440 into google-cloud-java.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 8, 2017
@garrettjonesgoogle garrettjonesgoogle merged commit 092cb79 into googleapis:master Nov 8, 2017
chingor13 pushed a commit that referenced this pull request Feb 20, 2026
* chore: remove integration tests for the deprecated v1beta2 write

* docs: update references to v1beta2 in JsonStreamWriter samples
chingor13 pushed a commit that referenced this pull request Mar 24, 2026
In this PR:
- Generate a selected list of libraries based on `library_name`

This PR is a preparation for improve nightly generation.

Note that we need to change the [new library generation
workflow](https://github.com/googleapis/google-cloud-java/blob/main/.github/workflows/generate_new_client_hermetic_build.yaml)
in google-cloud-java to accommodate this change because
`library_generation/generate_repo.py` has replaced
`--target-library-api-shortname` with `--target-library-names`.
chingor13 pushed a commit that referenced this pull request Mar 24, 2026
In todays's nightly generation job
([log](https://github.com/googleapis/google-cloud-java/actions/runs/8457767424/job/23170489394)),
no actual generation is done.

I think this is because `main` method has been removed by #2598.
chingor13 pushed a commit that referenced this pull request Mar 24, 2026
In this PR:
- In the integration test, run `generate_repo.py` and
`generate_pr_description.py` in docker container.
- Remove test image in cloud build.

Context: 
In this
[log](https://github.com/googleapis/google-cloud-java/actions/runs/8445620169/job/23133097820),
the nightly generation job only took 3 mins. After investigation, we
found out that removing `main` method in `generate_repo.py` (#2598)
caused the CLI is not running despite that the job returns successfully.

This non-explicit failure demonstrated that there's difference between
calling CLI (`generate` method in `generate_repo.py`) and its
implementation (`generate_from_yaml` method in `generate_repo.py`).

We decided to change the integration test to run the CLI in docker
container, rather than testing `generate_from_yaml` because it is the
containerized CLI will be used in downstream libraries.
chingor13 pushed a commit that referenced this pull request Mar 24, 2026
🤖 I have created a release *beep* *boop*
---


<details><summary>2.39.0</summary>

##
[2.39.0](googleapis/sdk-platform-java@v2.38.1...v2.39.0)
(2024-04-18)


### Features

* add `libraries_bom_version` to generation configuration
([#2639](googleapis/sdk-platform-java#2639))
([76eb62b](googleapis/sdk-platform-java@76eb62b))
* Add ChannelPoolSettings Getter for gRPC's ChannelProvider
([#2612](googleapis/sdk-platform-java#2612))
([c8dae8f](googleapis/sdk-platform-java@c8dae8f))
* add config change
([#2604](googleapis/sdk-platform-java#2604))
([a8c93b5](googleapis/sdk-platform-java@a8c93b5))
* add entry point
([#2616](googleapis/sdk-platform-java#2616))
([f5492bb](googleapis/sdk-platform-java@f5492bb))
* add generation config comparator
([#2587](googleapis/sdk-platform-java#2587))
([3461166](googleapis/sdk-platform-java@3461166))
* Add JavadocJar Task to build.gradle for self service libraries
([#2593](googleapis/sdk-platform-java#2593))
([a66df18](googleapis/sdk-platform-java@a66df18))
* Client/StubSettings' getEndpoint() returns the resolved endpoint
([#2440](googleapis/sdk-platform-java#2440))
([7cf0d8f](googleapis/sdk-platform-java@7cf0d8f))
* generate selected libraries
([#2598](googleapis/sdk-platform-java#2598))
([e4572d1](googleapis/sdk-platform-java@e4572d1))
* Validate the Universe Domain inside Java-Core
([#2592](googleapis/sdk-platform-java#2592))
([a5e1141](googleapis/sdk-platform-java@a5e1141))


### Bug Fixes

* add main to `generate_repo.py`
([#2607](googleapis/sdk-platform-java#2607))
([df39521](googleapis/sdk-platform-java@df39521))
* correct deep-remove and deep-preserve regexes
([#2572](googleapis/sdk-platform-java#2572))
([7d59fa1](googleapis/sdk-platform-java@7d59fa1))
* first attempt should use the min of RPC timeout and total timeout
([#2641](googleapis/sdk-platform-java#2641))
([806a52e](googleapis/sdk-platform-java@806a52e))
* remove duplicated calls to AutoValue builders
([#2636](googleapis/sdk-platform-java#2636))
([c883b8f](googleapis/sdk-platform-java@c883b8f))
* remove unnecessary slf4j and AbstractGoogleClientRequest native image
configs
([9cb7c09](googleapis/sdk-platform-java@9cb7c09))
* remove unnecessary slf4j and AbstractGoogleClientRequest native image
configs
([#2628](googleapis/sdk-platform-java#2628))
([9cb7c09](googleapis/sdk-platform-java@9cb7c09))


### Dependencies

* update arrow.version to v15.0.2
([#2589](googleapis/sdk-platform-java#2589))
([0947407](googleapis/sdk-platform-java@0947407))
* update dependency
com.google.cloud.opentelemetry:detector-resources-support to v0.28.0
([#2649](googleapis/sdk-platform-java#2649))
([079bcff](googleapis/sdk-platform-java@079bcff))
* update dependency gitpython to v3.1.41 [security]
([#2625](googleapis/sdk-platform-java#2625))
([018e9a9](googleapis/sdk-platform-java@018e9a9))
* update dependency net.bytebuddy:byte-buddy to v1.14.13
([#2646](googleapis/sdk-platform-java#2646))
([5a79cd2](googleapis/sdk-platform-java@5a79cd2))
* update dependency org.threeten:threeten-extra to v1.8.0
([#2650](googleapis/sdk-platform-java#2650))
([5666adb](googleapis/sdk-platform-java@5666adb))
* update dependency org.threeten:threetenbp to v1.6.9
([#2602](googleapis/sdk-platform-java#2602))
([767eec1](googleapis/sdk-platform-java@767eec1))
* update dependency org.threeten:threetenbp to v1.6.9
([#2665](googleapis/sdk-platform-java#2665))
([563d8ae](googleapis/sdk-platform-java@563d8ae))
* update google api dependencies
([#2584](googleapis/sdk-platform-java#2584))
([22733b1](googleapis/sdk-platform-java@22733b1))
* update googleapis/java-cloud-bom digest to 7071341
([#2608](googleapis/sdk-platform-java#2608))
([8f34fe7](googleapis/sdk-platform-java@8f34fe7))
* update netty dependencies to v4.1.109.final
([#2597](googleapis/sdk-platform-java#2597))
([6b6939e](googleapis/sdk-platform-java@6b6939e))
* update opentelemetry-java monorepo to v1.37.0
([#2652](googleapis/sdk-platform-java#2652))
([708cf7f](googleapis/sdk-platform-java@708cf7f))
* update protobuf dependencies to v3.25.3
([#2491](googleapis/sdk-platform-java#2491))
([e2235a8](googleapis/sdk-platform-java@e2235a8))
* update slf4j monorepo to v2.0.13
([#2647](googleapis/sdk-platform-java#2647))
([2e3d813](googleapis/sdk-platform-java@2e3d813))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
meltsufin pushed a commit that referenced this pull request Apr 29, 2026
meltsufin pushed a commit that referenced this pull request May 1, 2026
rahul2393 pushed a commit to akash329d/google-cloud-java that referenced this pull request May 21, 2026
…oogleapis#2598)

* feat: add getter for universe domain in JwtCredentialsWithAudience
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.