Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Requester pays: expose userProject#2554

Merged
andreamlin merged 7 commits into
googleapis:mastergoogleapis/google-cloud-java:masterfrom
andreamlin:requester_paysandreamlin/google-cloud-java:requester_paysCopy head branch name to clipboard
Oct 31, 2017
Merged

Requester pays: expose userProject#2554
andreamlin merged 7 commits into
googleapis:mastergoogleapis/google-cloud-java:masterfrom
andreamlin:requester_paysandreamlin/google-cloud-java:requester_paysCopy head branch name to clipboard

Conversation

@andreamlin

@andreamlin andreamlin commented Oct 26, 2017

Copy link
Copy Markdown
Contributor

Expose the userProject parameter for the List.Buckets operation.
Bump google-api-client dependency to 1.23.0.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 26, 2017
@andreamlin

Copy link
Copy Markdown
Contributor Author

Not ready for review; just running CI

@andreamlin andreamlin changed the title Requester pays Requester pays WIP Oct 26, 2017
@andreamlin andreamlin requested review from vam-google and removed request for garrettjonesgoogle October 26, 2017 16:59
@andreamlin

Copy link
Copy Markdown
Contributor Author

PTAL

@andreamlin andreamlin changed the title Requester pays WIP Requester pays: expose userProject Oct 26, 2017

@vam-google vam-google left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@garrettjonesgoogle Storage is a GA library and with this PR we update the underlying http and apiary clients used. I hope it is still ok, but please confirm.

.setMaxResults(Option.MAX_RESULTS.getLong(options))
.setPageToken(Option.PAGE_TOKEN.getString(options))
.setFields(Option.FIELDS.getString(options))
.setUserProject(Option.FIELDS.getString(options))

This comment was marked as spam.

This comment was marked as spam.

@garrettjonesgoogle

Copy link
Copy Markdown
Contributor

@vam-google updating the underlying http and apiary clients should be fine - they don't form part of the surface of google-cloud-storage.

@andreamlin

Copy link
Copy Markdown
Contributor Author

Fixed bugs. PTAL

@vam-google vam-google left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andreamlin andreamlin merged commit ca27145 into googleapis:master Oct 31, 2017
schmidt-sebastian pushed a commit to FirebasePrivate/google-cloud-java that referenced this pull request Nov 9, 2017
Expose the userProject parameter for the List.Buckets operation.
Bump google-api-client dependency to 1.23.0.
@andreamlin andreamlin deleted the requester_pays branch February 27, 2018 18:07
chingor13 pushed a commit that referenced this pull request Mar 24, 2026
…ping APIs (#2554)

After #2553 is merged, we do not need to add
`google/shopping/type/types.proto` in `generate_library.sh` as a special
case.
chingor13 pushed a commit that referenced this pull request Mar 30, 2026
* test: add mockito tests

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
rahul2393 pushed a commit to akash329d/google-cloud-java that referenced this pull request May 21, 2026
🤖 I have created a release *beep* *boop*
---


### Updating meta-information for bleeding-edge SNAPSHOT release.

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.