Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Using the pageable response from ListCollectionIds#2530

Merged
jabubake merged 4 commits into
googleapis:mastergoogleapis/google-cloud-java:masterfrom
FirebasePrivate:mrschmidt-pagedcollectionsFirebasePrivate/google-cloud-java:mrschmidt-pagedcollectionsCopy head branch name to clipboard
Oct 19, 2017
Merged

Using the pageable response from ListCollectionIds#2530
jabubake merged 4 commits into
googleapis:mastergoogleapis/google-cloud-java:masterfrom
FirebasePrivate:mrschmidt-pagedcollectionsFirebasePrivate/google-cloud-java:mrschmidt-pagedcollectionsCopy head branch name to clipboard

Conversation

@schmidt-sebastian

@schmidt-sebastian schmidt-sebastian commented Oct 16, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

This is a breaking API change, but it allows us to use a Java iterator to fetch all collection IDs. Right now, the total number of IDs is capped at 20.

I removed the unit tests since I am unable to figure out how to build a ListCollectionIdsPagedResponse :/ Let me know if you have a suggestion.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 16, 2017
@schmidt-sebastian schmidt-sebastian force-pushed the mrschmidt-pagedcollections branch from c2b0f8a to 33fee03 Compare October 16, 2017 23:47
@pongad

pongad commented Oct 16, 2017

Copy link
Copy Markdown
Contributor

LGTM; I'll let Garrrett +2

@schmidt-sebastian
Using the pageable response from ListCollectionIds
4c2b8c3 
This is a breaking API change, but it allows us to use a Java iterator to fetch all collection IDs. Right now, the total number of IDs are capped at 20.
@schmidt-sebastian schmidt-sebastian force-pushed the mrschmidt-pagedcollections branch from 33fee03 to 4c2b8c3 Compare October 17, 2017 00:00
garrettjonesgoogle
garrettjonesgoogle reviewed Oct 17, 2017
View reviewed changes

@garrettjonesgoogle garrettjonesgoogle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the ListCollectionIdsPagedResponse class has a private constructor. I think this case means we should change our code generation to make it accessible.

Comment thread google-cloud-firestore/src/main/java/com/google/cloud/firestore/Firestore.java Outdated
*/
@Nonnull
ApiFuture<List<CollectionReference>> getCollections();
Iterable<CollectionReference> getCollections() throws ExecutionException, InterruptedException;

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@schmidt-sebastian schmidt-sebastian force-pushed the mrschmidt-pagedcollections branch from 6147a15 to 4582509 Compare October 17, 2017 23:39
@schmidt-sebastian schmidt-sebastian force-pushed the mrschmidt-pagedcollections branch 3 times, most recently from a19b923 to 5a3d707 Compare October 19, 2017 00:39
@schmidt-sebastian schmidt-sebastian force-pushed the mrschmidt-pagedcollections branch from 5a3d707 to a09224b Compare October 19, 2017 00:48
@schmidt-sebastian

schmidt-sebastian commented Oct 19, 2017

Copy link
Copy Markdown
Contributor Author

Feedback addressed. FirestoreException now inherits from BaseGrpcServiceException.

@garrettjonesgoogle

garrettjonesgoogle commented Oct 19, 2017

Copy link
Copy Markdown
Contributor

LGTM

@jabubake jabubake merged commit ae2ac53 into googleapis:master Oct 19, 2017
@jabubake

jabubake commented Oct 19, 2017

Copy link
Copy Markdown
Contributor

Merged for @schmidt-sebastian

schmidt-sebastian added a commit to FirebasePrivate/google-cloud-java that referenced this pull request Nov 9, 2017
@schmidt-sebastian
Using the pageable response from ListCollectionIds (googleapis#2530)
8f522c1
chingor13 pushed a commit that referenced this pull request Feb 20, 2026
@renovate-bot @gcf-owl-bot @PhongChuong
deps: update actions/checkout digest to 692973e (#2530)
3f2e689 
* deps: update actions/checkout digest to 692973e

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Phong Chuong <147636638+PhongChuong@users.noreply.github.com>
chingor13 pushed a commit that referenced this pull request Mar 24, 2026
@renovate-bot
deps: update dependency com.google.errorprone:error_prone_annotations…
545dfa1 
… to v2.26.1 (#2530)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[com.google.errorprone:error_prone_annotations](https://errorprone.info)
([source](https://togithub.com/google/error-prone)) | `2.24.1` ->
`2.26.1` |
[![age](https://developer.mend.io/api/mc/badges/age/maven/com.google.errorprone:error_prone_annotations/2.26.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/com.google.errorprone:error_prone_annotations/2.26.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/com.google.errorprone:error_prone_annotations/2.24.1/2.26.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/com.google.errorprone:error_prone_annotations/2.24.1/2.26.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>google/error-prone
(com.google.errorprone:error_prone_annotations)</summary>

###
[`v2.26.1`](https://togithub.com/google/error-prone/releases/tag/v2.26.1):
Error Prone 2.26.1

[Compare
Source](https://togithub.com/google/error-prone/compare/v2.26.0...v2.26.1)

Changes:

- Fix the module name of the annotations artifact:
`com.google.errorprone.annotations`
(google/error-prone@9d99ee7)

Full Changelog:
google/error-prone@v2.26.0...v2.26.1

###
[`v2.26.0`](https://togithub.com/google/error-prone/releases/tag/v2.26.0):
Error Prone 2.26.0

[Compare
Source](https://togithub.com/google/error-prone/compare/v2.25.0...v2.26.0)

Changes:

- The 'annotations' artifact now includes a `module-info.java` for Java
Platform Module System support, thanks to
[@&#8203;sgammon](https://togithub.com/sgammon) in
[#&#8203;4311](https://togithub.com/google/error-prone/issues/4311).
- Disabled checks passed to `-XepPatchChecks` are now ignored, instead
of causing a crash. Thanks to
[@&#8203;oxkitsune](https://togithub.com/oxkitsune) in
[#&#8203;4028](https://togithub.com/google/error-prone/issues/4028).

New checks:

-
[`SystemConsoleNull`](https://errorprone.info/bugpattern/SystemConsoleNull):
Null-checking `System.console()` is not a reliable way to detect if the
console is connected to a terminal.
- [`EnumOrdinal`](https://errorprone.info/bugpattern/EnumOrdinal):
Discourage uses of `Enum.ordinal()`

Closed issues:
[#&#8203;2649](https://togithub.com/google/error-prone/issues/2649),
[#&#8203;3908](https://togithub.com/google/error-prone/issues/3908),
[#&#8203;4028](https://togithub.com/google/error-prone/issues/4028),
[#&#8203;4311](https://togithub.com/google/error-prone/issues/4311),
[#&#8203;4314](https://togithub.com/google/error-prone/issues/4314)

Full Changelog:
google/error-prone@v2.25.0...v2.26.0

###
[`v2.25.0`](https://togithub.com/google/error-prone/releases/tag/v2.25.0):
Error Prone 2.25.0

[Compare
Source](https://togithub.com/google/error-prone/compare/v2.24.1...v2.25.0)

New checks:

-
[`JUnitIncompatibleType`](https://errorprone.info/bugpattern/JUnitIncompatibleType):
Detects incompatible types passed to an assertion, similar to [`
TruthIncompatibleType
`](https://errorprone.info/bugpattern/TruthIncompatibleType)
-
[`RedundantSetterCall`](https://errorprone.info/bugpattern/RedundantSetterCall):
Detects fields set twice in the same chained expression. Generalization
of previous `ProtoRedundantSet` check to also handle
[AutoValue](https://togithub.com/google/auto/blob/main/value/userguide/index.md).

Closed issues:
[#&#8203;4195](https://togithub.com/google/error-prone/issues/4195),
[#&#8203;4224](https://togithub.com/google/error-prone/issues/4224),
[#&#8203;4228](https://togithub.com/google/error-prone/issues/4228),
[#&#8203;4248](https://togithub.com/google/error-prone/issues/4248),
[#&#8203;4249](https://togithub.com/google/error-prone/issues/4249),
[#&#8203;4251](https://togithub.com/google/error-prone/issues/4251)

Full Changelog:
google/error-prone@v2.24.1...v2.25.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/googleapis/sdk-platform-java).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMjAuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI0NS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
chingor13 pushed a commit that referenced this pull request Mar 24, 2026
@release-please
chore(main): release 2.38.0 (#2529)
2423b32 
🤖 I have created a release *beep* *boop*
---


<details><summary>2.38.0</summary>

##
[2.38.0](googleapis/sdk-platform-java@v2.37.0...v2.38.0)
(2024-03-15)


### Features

* [common-protos] add `api_version` extension to `ServiceOptions`, for
collaborative versioning
([95fd22c](googleapis/sdk-platform-java@95fd22c))
* [common-protos] add `api_version` extension to `ServiceOptions`, for
collaborative versioning
([#2551](googleapis/sdk-platform-java#2551))
([95fd22c](googleapis/sdk-platform-java@95fd22c))
* add `ErrorReason.LOCATION_POLICY_VIOLATED` enum value
([95fd22c](googleapis/sdk-platform-java@95fd22c))
* add `ErrorReason.LOCATION_POLICY_VIOLATED` enum value
([95fd22c](googleapis/sdk-platform-java@95fd22c))
* add `Publishing.rest_reference_documentation_uri` to aid client
library publication
([95fd22c](googleapis/sdk-platform-java@95fd22c))
* add `Publishing.rest_reference_documentation_uri` to aid client
library publication
([95fd22c](googleapis/sdk-platform-java@95fd22c))
* Add shopping and chat common protos.
([#2553](googleapis/sdk-platform-java#2553))
([14769d3](googleapis/sdk-platform-java@14769d3)),
closes
[#2018](googleapis/sdk-platform-java#2018)
* get PR description from googleapis commits
([#2531](googleapis/sdk-platform-java#2531))
([d26580c](googleapis/sdk-platform-java@d26580c))
* Introduce OpenTelemetry Metrics Recording
([#2500](googleapis/sdk-platform-java#2500))
([27c3a20](googleapis/sdk-platform-java@27c3a20))
* skip build only commit
([#2555](googleapis/sdk-platform-java#2555))
([002790e](googleapis/sdk-platform-java@002790e))
* Universe Domain Environment Variable Support
([#2485](googleapis/sdk-platform-java#2485))
([b2b0414](googleapis/sdk-platform-java@b2b0414))


### Dependencies

* normalize dependencies
([#2574](googleapis/sdk-platform-java#2574))
([bd10d40](googleapis/sdk-platform-java@bd10d40))
* update arrow.version to v15.0.1
([#2565](googleapis/sdk-platform-java#2565))
([a652d47](googleapis/sdk-platform-java@a652d47))
* update dependency com.fasterxml.jackson:jackson-bom to v2.17.0
([#2564](googleapis/sdk-platform-java#2564))
([f099a56](googleapis/sdk-platform-java@f099a56))
* update dependency com.google.api-client:google-api-client-bom to
v2.4.0
([#2570](googleapis/sdk-platform-java#2570))
([720a917](googleapis/sdk-platform-java@720a917))
* update dependency com.google.errorprone:error_prone_annotations to
v2.26.1
([#2530](googleapis/sdk-platform-java#2530))
([545dfa1](googleapis/sdk-platform-java@545dfa1))
* update dependency com.google.errorprone:error_prone_annotations to
v2.26.1
([#2532](googleapis/sdk-platform-java#2532))
([8861143](googleapis/sdk-platform-java@8861143))
* update dependency io.netty:netty-tcnative-boringssl-static to
v2.0.65.final
([#2547](googleapis/sdk-platform-java#2547))
([b516f3c](googleapis/sdk-platform-java@b516f3c))
* update dependency net.bytebuddy:byte-buddy to v1.14.12
([#2522](googleapis/sdk-platform-java#2522))
([60b5626](googleapis/sdk-platform-java@60b5626))
* update google api dependencies
([#2484](googleapis/sdk-platform-java#2484))
([3ed98b1](googleapis/sdk-platform-java@3ed98b1))
* update google api dependencies
([#2538](googleapis/sdk-platform-java#2538))
([7f5f925](googleapis/sdk-platform-java@7f5f925))
* update googleapis/java-cloud-bom digest to 3f93d58
([#2499](googleapis/sdk-platform-java#2499))
([d557d96](googleapis/sdk-platform-java@d557d96))
* update googleapis/java-cloud-bom digest to 659764f
([#2545](googleapis/sdk-platform-java#2545))
([144e461](googleapis/sdk-platform-java@144e461))
* update netty dependencies
([#2480](googleapis/sdk-platform-java#2480))
([d43592b](googleapis/sdk-platform-java@d43592b))
* update opentelemetry-java monorepo to v1.35.0
([#2477](googleapis/sdk-platform-java#2477))
([e34028f](googleapis/sdk-platform-java@e34028f))
* update opentelemetry-java monorepo to v1.36.0
([#2550](googleapis/sdk-platform-java#2550))
([31737f2](googleapis/sdk-platform-java@31737f2))
* update opentelemetry-java monorepo to v1.36.0
([#2573](googleapis/sdk-platform-java#2573))
([4653e2c](googleapis/sdk-platform-java@4653e2c))
* update slf4j monorepo to v2.0.12
([#2481](googleapis/sdk-platform-java#2481))
([29332ce](googleapis/sdk-platform-java@29332ce))


### Documentation

* minor tweaks to various comments
([95fd22c](googleapis/sdk-platform-java@95fd22c))
* minor tweaks to various comments
([95fd22c](googleapis/sdk-platform-java@95fd22c))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@garrettjonesgoogle garrettjonesgoogle garrettjonesgoogle left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@schmidt-sebastian @pongad @garrettjonesgoogle @jabubake @googlebot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.