Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

fixing broken test - cloud/spanner/SessionPoolIntegrationTest.java#2495

Merged
vkedia merged 3 commits into
mastergoogleapis/google-cloud-java:masterfrom
snehashah-bugfixgoogleapis/google-cloud-java:snehashah-bugfixCopy head branch name to clipboard
Oct 10, 2017
Merged

fixing broken test - cloud/spanner/SessionPoolIntegrationTest.java#2495
vkedia merged 3 commits into
mastergoogleapis/google-cloud-java:masterfrom
snehashah-bugfixgoogleapis/google-cloud-java:snehashah-bugfixCopy head branch name to clipboard

Conversation

@snehashah16

@snehashah16 snehashah16 commented Oct 9, 2017

Copy link
Copy Markdown
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 9, 2017
@vkedia

vkedia commented Oct 9, 2017

Copy link
Copy Markdown

@vam-google Would you know why this test does not run on travis? That is why we never caught this issue. This is an integration test.

@snehashah16

snehashah16 commented Oct 9, 2017

Copy link
Copy Markdown
Contributor Author

@vkedia - added some more java style, unused and other fixes.

@vkedia

vkedia commented Oct 10, 2017

Copy link
Copy Markdown

I see this error in appveyor build:
[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR] /C:/projects/google-cloud-java-v0gf7/google-cloud-spanner/src/test/java/com/google/cloud/spanner/SessionPoolOptionsTest.java:[38,6] cannot find symbol
symbol: class Parameter
location: class com.google.cloud.spanner.SessionPoolOptionsTest
[ERROR] /C:/projects/google-cloud-java-v0gf7/google-cloud-spanner/src/test/java/com/google/cloud/spanner/SessionPoolOptionsTest.java:[40,6] cannot find symbol
symbol: class Parameter
location: class com.google.cloud.spanner.SessionPoolOptionsTest
[ERROR] /C:/projects/google-cloud-java-v0gf7/google-cloud-spanner/src/test/java/com/google/cloud/spanner/SessionPoolOptionsTest.java:[38,6] cannot find symbol
symbol: class Parameter
location: class com.google.cloud.spanner.SessionPoolOptionsTest
[ERROR] /C:/projects/google-cloud-java-v0gf7/google-cloud-spanner/src/test/java/com/google/cloud/spanner/SessionPoolOptionsTest.java:[40,6] cannot find symbol
symbol: class Parameter
location: class com.google.cloud.spanner.SessionPoolOptionsTest
[INFO] 4 errors

@snehashah16

snehashah16 commented Oct 10, 2017

Copy link
Copy Markdown
Contributor Author

@vkedia - fixed missing import.

@vkedia vkedia merged commit 43d8c48 into master Oct 10, 2017
@pongad pongad deleted the snehashah-bugfix branch March 8, 2018 23:25
chingor13 pushed a commit that referenced this pull request Feb 20, 2026
@gcf-owl-bot
chore: update dependency versions in java templates (#1964) (#2495)
4600976 
* chore: update dependency versions in java templates

* update other templates
Source-Link: googleapis/synthtool@0b86c72
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:68ba5f5164a4b55529d358bb262feaa000536a0c62980727dd05a91bbb47ea5e

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
chingor13 pushed a commit that referenced this pull request Mar 30, 2026
@BenWhitehead
chore(samples): update UploadObjectFromMemory to use the most appropr…
487e3e7 
…iate method (#2495)
rahul2393 pushed a commit to akash329d/google-cloud-java that referenced this pull request May 21, 2026
@nicholsl
chore: fork ChannelPool and ChannelPoolSettings into gaxx/grpc (googl…
ea64358 
…eapis#2496)

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [x] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/java-bigtable/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea - https://togithub.com/googleapis/java-bigtable/issues/2495
- [x] Ensure the tests and linter pass
- [x] Code coverage does not decrease (if any source code was changed)
- [x] Appropriate docs were updated (if necessary) (N/A)
- [x] Rollback plan is reviewed and LGTMed (N/A)
- [x] All new data plane features have a completed end to end testing plan (N/A)

Fixes googleapis#2495 ☕️

If you write sample code, please follow the [samples format](
https://togithub.com/GoogleCloudPlatform/java-docs-samples/blob/main/SAMPLE_FORMAT.md).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@garrettjonesgoogle garrettjonesgoogle Awaiting requested review from garrettjonesgoogle
1 more reviewer
@vkedia vkedia vkedia approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@snehashah16 @vkedia @googlebot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.