Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix confusing Translation sample code#2394

Merged
vam-google merged 2 commits into
googleapis:mastergoogleapis/google-cloud-java:masterfrom
vam-google:mastervam-google/google-cloud-java:masterCopy head branch name to clipboard
Aug 30, 2017
Merged

Fix confusing Translation sample code#2394
vam-google merged 2 commits into
googleapis:mastergoogleapis/google-cloud-java:masterfrom
vam-google:mastervam-google/google-cloud-java:masterCopy head branch name to clipboard

Conversation

@vam-google

Copy link
Copy Markdown
Contributor

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 30, 2017
String detectedLanguage = detection.getLanguage();

// Translate some text
// Translate the mysterious text from Spanish to English

This comment was marked as spam.

@vam-google vam-google requested review from garrettjonesgoogle and removed request for garrettjonesgoogle August 30, 2017 19:16
@vam-google

Copy link
Copy Markdown
Contributor Author

PTAL

@garrettjonesgoogle garrettjonesgoogle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vam-google vam-google merged commit a8f4b7c into googleapis:master Aug 30, 2017
suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 23, 2026
chingor13 pushed a commit that referenced this pull request Mar 24, 2026
* sample: add support for Directed Read options

* add additional assertion on output from sample

* fix nit

Co-authored-by: Knut Olav Løite <koloite@gmail.com>

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* feat: update setter

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* feat: update comment

* feat: update comment

* feat: add additional comments

* feat: lint fix

---------

Co-authored-by: Knut Olav Løite <koloite@gmail.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Sri Harsha CH <57220027+harshachinta@users.noreply.github.com>
Co-authored-by: Sri Harsha CH <sriharshach@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.