Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Create CODEOWNERS file#2388

Merged
vam-google merged 4 commits into
mastergoogleapis/google-cloud-java:masterfrom
vam-google-patch-CODEOWNERSgoogleapis/google-cloud-java:vam-google-patch-CODEOWNERSCopy head branch name to clipboard
Aug 30, 2017
Merged

Create CODEOWNERS file#2388
vam-google merged 4 commits into
mastergoogleapis/google-cloud-java:masterfrom
vam-google-patch-CODEOWNERSgoogleapis/google-cloud-java:vam-google-patch-CODEOWNERSCopy head branch name to clipboard

Conversation

@vam-google

Copy link
Copy Markdown
Contributor

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 28, 2017
Comment thread .github/CODEOWNERS Outdated
google-cloud-pubsub/* @pongad
google-cloud-resourcemanager/* @garrettjonesgoogle
google-cloud-spanner/* @vam
google-cloud-speech/* @shinfan

This comment was marked as spam.

Comment thread .github/CODEOWNERS Outdated
google-cloud-trace/* @garrettjonesgoogle
google-cloud-translate/* @garrettjonesgoogle
google-cloud-util/* @garrettjonesgoogle
google-cloud-video-intelligence/* @shinfan

This comment was marked as spam.

Comment thread .github/CODEOWNERS Outdated
google-cloud-errorreporting/* @garrettjonesgoogle
google-cloud-examples/* @garrettjonesgoogle
google-cloud-language/* @garrettjonesgoogle
google-cloud-logging/* @garrettjonesgoogle

This comment was marked as spam.

Comment thread .github/CODEOWNERS Outdated

google-cloud-bigquery/* @vam
google-cloud-compute/* @garrettjonesgoogle
google-cloud-contrib/* @garrettjonesgoogle

This comment was marked as spam.

Comment thread .github/CODEOWNERS Outdated
# Code owners file.
# This file controls who is tagged for review for any given pull request.

google-cloud-bigquery/* @vam

This comment was marked as spam.

@shinfan

shinfan commented Aug 28, 2017

Copy link
Copy Markdown
Contributor

@vam-google Feel free to transfer my ownership to @garrettjonesgoogle (as the default owner)

@vam-google

Copy link
Copy Markdown
Contributor Author

PTAL

@pongad

pongad commented Aug 28, 2017

Copy link
Copy Markdown
Contributor

When committing, rename 'crate' to 'create'. Otherwise, LGTM for pubsub

@vam-google vam-google changed the title Crate CODEOWNERS file Create CODEOWNERS file Aug 28, 2017
@garrettjonesgoogle

Copy link
Copy Markdown
Contributor

LGTM

@vam-google vam-google merged commit b4c823d into master Aug 30, 2017
@tswast

tswast commented Sep 5, 2017

Copy link
Copy Markdown
Contributor

LGTM

@pongad pongad deleted the vam-google-patch-CODEOWNERS branch March 8, 2018 23:25
chingor13 pushed a commit that referenced this pull request Feb 20, 2026
…-config (#2679)

These dependencies were added in #2388 with hardcoded versions.
We prefer getting these versions from sdk-platform-java-config (includes both auth and gax versions).

auth is included in dependencyManagement here in gapic-generator-java-bom, which is part of first-party-dependencies, and eventually included via sdk-platform-java-config.
meltsufin pushed a commit that referenced this pull request Apr 29, 2026
* docs(sample): Add samples for topic and subscription SMTs

* docs(sample): Add samples for topic and subscription SMTs

* Fix missing paren

* Formatting fixes
meltsufin pushed a commit that referenced this pull request May 1, 2026
* docs(sample): Add samples for topic and subscription SMTs

* docs(sample): Add samples for topic and subscription SMTs

* Fix missing paren

* Formatting fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.