Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Using Jobs.insert instead of Jobs.query for queries#2323

Merged
garrettjonesgoogle merged 2 commits into
mastergoogleapis/google-cloud-java:masterfrom
altgoogleapis/google-cloud-java:altCopy head branch name to clipboard
Aug 10, 2017
Merged

Using Jobs.insert instead of Jobs.query for queries#2323
garrettjonesgoogle merged 2 commits into
mastergoogleapis/google-cloud-java:masterfrom
altgoogleapis/google-cloud-java:altCopy head branch name to clipboard

Conversation

@garrettjonesgoogle

@garrettjonesgoogle garrettjonesgoogle commented Aug 9, 2017

Copy link
Copy Markdown
Contributor

Fixes #1588 .

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 9, 2017
tswast
tswast reviewed Aug 9, 2017
View reviewed changes

@tswast tswast left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see two changes in here:

  1. add query params to the query job config. Those changes look fine to me.
  2. Add job ID argument to query function. I think we might want to go a step further and remove the QueryResponse / QueryRequest classes.

Comment thread google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/BigQuery.java
@@ -986,6 +986,19 @@ Page<List<FieldValue>> listTableData(String datasetId, String tableId,
*/

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@garrettjonesgoogle

garrettjonesgoogle commented Aug 9, 2017

Copy link
Copy Markdown
Contributor Author

How about I just make the new function @BetaApi, since we'll go and break it later?

tswast
tswast approved these changes Aug 9, 2017
View reviewed changes

@tswast tswast left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Makes sense to limit the scope and mark as @BetaAPI to indicate it's likely to break.

These changes as-is are a big improvement. Thanks.

@garrettjonesgoogle garrettjonesgoogle merged commit 303f43c into master Aug 10, 2017
@garrettjonesgoogle garrettjonesgoogle mentioned this pull request Aug 10, 2017
Closed
@pongad pongad deleted the alt branch March 8, 2018 23:25
chingor13 pushed a commit that referenced this pull request Feb 20, 2026
@release-please
chore(main): release 2.46.1-SNAPSHOT (#2323)
63034a1 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 23, 2026
@renovate-bot
deps: update dependency org.testcontainers:testcontainers to v2.0.3 (g…
aaa6683 
…oogleapis#2323)
suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 23, 2026
@release-please
chore(main): release 2.34.1 (googleapis#2305)
3d96a26 
🤖 I have created a release *beep* *boop*
---


## [2.34.1](https://togithub.com/googleapis/java-spanner-jdbc/compare/v2.34.0...v2.34.1) (2025-12-16)


### Bug Fixes

* Cast double Inf and NaN to float ([googleapis#2304](https://togithub.com/googleapis/java-spanner-jdbc/issues/2304)) ([58d0670](https://togithub.com/googleapis/java-spanner-jdbc/commit/58d067076d16f50573e53991e25fc5f3935d2a19)), closes [googleapis#2256](https://togithub.com/googleapis/java-spanner-jdbc/issues/2256)


### Dependencies

* Update actions/checkout action to v6 ([googleapis#2299](https://togithub.com/googleapis/java-spanner-jdbc/issues/2299)) ([b89fbc8](https://togithub.com/googleapis/java-spanner-jdbc/commit/b89fbc804a8b675e47ecdc566ee49df3427beb19))
* Update dependency com.google.cloud:google-cloud-spanner to v6.104.0 ([googleapis#2312](https://togithub.com/googleapis/java-spanner-jdbc/issues/2312)) ([3f81243](https://togithub.com/googleapis/java-spanner-jdbc/commit/3f812434cddebdabbf8403807ad284fa40eeee25))
* Update dependency com.google.cloud:google-cloud-spanner to v6.105.0 ([googleapis#2325](https://togithub.com/googleapis/java-spanner-jdbc/issues/2325)) ([6b97652](https://togithub.com/googleapis/java-spanner-jdbc/commit/6b97652432c42887241a94e649331d77c8dccfbc))
* Update dependency com.google.cloud:google-cloud-spanner-bom to v6.104.0 ([googleapis#2313](https://togithub.com/googleapis/java-spanner-jdbc/issues/2313)) ([bc371a8](https://togithub.com/googleapis/java-spanner-jdbc/commit/bc371a893801853723ab0c12245d69638044c733))
* Update dependency com.google.cloud:google-cloud-spanner-bom to v6.105.0 ([googleapis#2326](https://togithub.com/googleapis/java-spanner-jdbc/issues/2326)) ([3122d1c](https://togithub.com/googleapis/java-spanner-jdbc/commit/3122d1c2c758cfa7565ba4a937f27fcfe4589863))
* Update dependency com.google.cloud:sdk-platform-java-config to v3.54.2 ([googleapis#2322](https://togithub.com/googleapis/java-spanner-jdbc/issues/2322)) ([37ce0f7](https://togithub.com/googleapis/java-spanner-jdbc/commit/37ce0f72d5bc38461b2002ec2a26311d92b7dc8c))
* Update dependency io.opentelemetry:opentelemetry-bom to v1.57.0 ([googleapis#2316](https://togithub.com/googleapis/java-spanner-jdbc/issues/2316)) ([6e41a1e](https://togithub.com/googleapis/java-spanner-jdbc/commit/6e41a1ec3a422a0f76fd864a15163a18fb9d03c3))
* Update dependency net.bytebuddy:byte-buddy to v1.18.2 ([googleapis#2306](https://togithub.com/googleapis/java-spanner-jdbc/issues/2306)) ([28b47ed](https://togithub.com/googleapis/java-spanner-jdbc/commit/28b47edec46a220ccb1b5759c58d152c94271156))
* Update dependency net.bytebuddy:byte-buddy-agent to v1.18.2 ([googleapis#2307](https://togithub.com/googleapis/java-spanner-jdbc/issues/2307)) ([ba29e83](https://togithub.com/googleapis/java-spanner-jdbc/commit/ba29e835248385bb5a7ad2ceec12eca8cdd7792d))
* Update dependency org.springframework.boot:spring-boot to v4 ([googleapis#2300](https://togithub.com/googleapis/java-spanner-jdbc/issues/2300)) ([beba91c](https://togithub.com/googleapis/java-spanner-jdbc/commit/beba91c5efc89362aa1f3f9418b17e744c90b6cf))
* Update dependency org.springframework.boot:spring-boot-starter-data-jdbc to v4 ([googleapis#2301](https://togithub.com/googleapis/java-spanner-jdbc/issues/2301)) ([1d0b5d4](https://togithub.com/googleapis/java-spanner-jdbc/commit/1d0b5d40cc41d903cad3c1c63c473b86143665a3))
* Update dependency org.springframework.boot:spring-boot-starter-parent to v3.5.8 ([googleapis#2298](https://togithub.com/googleapis/java-spanner-jdbc/issues/2298)) ([5a9c025](https://togithub.com/googleapis/java-spanner-jdbc/commit/5a9c025fae0904ec4870c1db5b0dc4cfb63b08fc))
* Update dependency org.testcontainers:testcontainers to v2.0.3 ([googleapis#2323](https://togithub.com/googleapis/java-spanner-jdbc/issues/2323)) ([aaa6683](https://togithub.com/googleapis/java-spanner-jdbc/commit/aaa6683885736214612949445934b6de499667b1))
* Update dependency org.testcontainers:testcontainers-bom to v2.0.3 ([googleapis#2324](https://togithub.com/googleapis/java-spanner-jdbc/issues/2324)) ([92dc391](https://togithub.com/googleapis/java-spanner-jdbc/commit/92dc39111a365d56969d5cad7856f8a867c8968b))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
meltsufin pushed a commit that referenced this pull request Apr 29, 2026
@cloud-java-bot
chore: Update generation configuration at Tue Jan 28 02:23:29 UTC 2025 (
a5fd79a 
#2323)
meltsufin pushed a commit that referenced this pull request May 1, 2026
@cloud-java-bot
chore: Update generation configuration at Tue Jan 28 02:23:29 UTC 2025 (
b43443c 
#2323)
meltsufin pushed a commit that referenced this pull request May 2, 2026
@cherylEnkidu @cloud-java-bot
feat: Add subquery support in pipeline (#2323)
e1fc530 
* save work

* Fix breaking tests

* Fix testSingleLookupScalarSubquery

* Fix broken tests

* change syntax for define and return type of as function

* add documentation and overload for getField()

* change proto

* chore: generate libraries at Thu Feb 26 19:35:06 UTC 2026

* format code

* add tests for toArrayExpression

* move the subquery test to independent file

* Add tests for subcollection

* Format code

* refactor PipelineExpression

* Address feedbacks

* Improve documentation

* change the test

* Test subcollection used within Union stage

* replace mapGet with getField

* support subcollection in test

* chore: generate libraries at Wed Mar 11 18:14:28 UTC 2026

* improve error message

* chore: generate libraries at Tue Mar 24 17:04:45 UTC 2026

* add decode support

* Make the subquery test only run in nightly environment

* address feedbacks

* chore: generate libraries at Fri Mar 27 22:19:12 UTC 2026

* remove beta annotation

---------

Co-authored-by: cloud-java-bot <cloud-java-bot@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tswast tswast tswast approved these changes
@vam-google vam-google Awaiting requested review from vam-google

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@garrettjonesgoogle @tswast @googlebot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.