Make sure Storage does not do name normalization by shinfan · Pull Request #1908 · googleapis/google-cloud-java

shinfan · Apr 12, 2017

jskeet · Apr 12, 2017

Sorry, I'm on vacation until Tuesday so I probably won't be able to review this until then.

Sign in to view

+  @Test
+  public void testBlobNameNormalization() {
+    for (String blobName : BLOB_NORMALIZATION.keySet()) {
+      BlobInfo blobInfoFormC = BlobInfo.newBuilder(BlobId.of(BUCKET, blobName))


shinfan · Apr 12, 2017

@jskeet No worries :)

coveralls · Apr 12, 2017

Coverage decreased (-0.004%) to 80.969% when pulling 698ea95 on shinfan:master into f9e7ecc on GoogleCloudPlatform:master.

coveralls · Apr 13, 2017

Coverage increased (+0.004%) to 80.955% when pulling 851e93c on shinfan:master into 56d0a30 on GoogleCloudPlatform:master.

Sign in to view

+          .setContentType("text/plain")
+          .setContentEncoding("UTF-8")
+          .build();
+      Blob blob = storage.create(blobInfo, BLOB_NORMALIZATION.get(blobName).getBytes());


coveralls · May 18, 2017

Coverage decreased (-0.002%) to 80.94% when pulling 14fae1e on shinfan:master into c73d3b0 on GoogleCloudPlatform:master.

shinfan · May 18, 2017

Oops I updated this branch by mistake. I will fix this.

coveralls · Jun 26, 2017

Changes Unknown when pulling b37a624 on shinfan:master into ** on GoogleCloudPlatform:master**.

garrettjonesgoogle · Jul 18, 2017

@shinfan could you maybe create a PR off of a different branch so that it isn't prone to getting overwritten?

…p/templates/java_library/.kokoro (#1908) (#1491) build(deps): bump cryptography Bumps [cryptography](https://github.com/pyca/cryptography) from 41.0.3 to 41.0.6. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@41.0.3...41.0.6) --- updated-dependencies: - dependency-name: cryptography dependency-type: indirect ... Source-Link: googleapis/synthtool@ea6f800 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:81f75d962cd28b7ad10740a643b8069b8fa0357cb495b782eef8560bb7a8fd65 Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Cindy Peng <148148319+cindy-peng@users.noreply.github.com>

…p/templates/java_library/.kokoro (#1908) (#1225) build(deps): bump cryptography Bumps [cryptography](https://github.com/pyca/cryptography) from 41.0.3 to 41.0.6. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@41.0.3...41.0.6) --- updated-dependencies: - dependency-name: cryptography dependency-type: indirect ... Source-Link: googleapis/synthtool@ea6f800 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:81f75d962cd28b7ad10740a643b8069b8fa0357cb495b782eef8560bb7a8fd65 Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Cindy Peng <148148319+cindy-peng@users.noreply.github.com>

…p/templates/java_library/.kokoro (#1908) (#1256) build(deps): bump cryptography Bumps [cryptography](https://github.com/pyca/cryptography) from 41.0.3 to 41.0.6. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@41.0.3...41.0.6) --- updated-dependencies: - dependency-name: cryptography dependency-type: indirect ... Source-Link: googleapis/synthtool@ea6f800 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:81f75d962cd28b7ad10740a643b8069b8fa0357cb495b782eef8560bb7a8fd65 Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…v3.50.1 (#1908) Co-authored-by: Cindy Peng <148148319+cindy-peng@users.noreply.github.com>

…p/templates/java_library/.kokoro (#1908) (#2354) build(deps): bump cryptography Bumps [cryptography](https://github.com/pyca/cryptography) from 41.0.3 to 41.0.6. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@41.0.3...41.0.6) --- updated-dependencies: - dependency-name: cryptography dependency-type: indirect ... Source-Link: googleapis/synthtool@ea6f800 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:81f75d962cd28b7ad10740a643b8069b8fa0357cb495b782eef8560bb7a8fd65 Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…p/templates/java_library/.kokoro (googleapis#1908) (googleapis#1491) build(deps): bump cryptography Bumps [cryptography](https://github.com/pyca/cryptography) from 41.0.3 to 41.0.6. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@41.0.3...41.0.6) --- updated-dependencies: - dependency-name: cryptography dependency-type: indirect ... Source-Link: googleapis/synthtool@ea6f800 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:81f75d962cd28b7ad10740a643b8069b8fa0357cb495b782eef8560bb7a8fd65 Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Cindy Peng <148148319+cindy-peng@users.noreply.github.com>

…v3.50.1 (#1908) Co-authored-by: Cindy Peng <148148319+cindy-peng@users.noreply.github.com>

🤖 I have created a release *beep* *boop* --- ## [2.31.0](https://togithub.com/googleapis/java-datastore/compare/v2.30.0...v2.31.0) (2025-07-14) ### Features * Next release from main branch is 2.31.0 ([#1912](https://togithub.com/googleapis/java-datastore/issues/1912)) ([af29fa0](https://togithub.com/googleapis/java-datastore/commit/af29fa0641612ca060f72d3f70534a88d19e1358)) ### Dependencies * Update dependency com.google.cloud:gapic-libraries-bom to v1.61.0 ([#1901](https://togithub.com/googleapis/java-datastore/issues/1901)) ([f66bd14](https://togithub.com/googleapis/java-datastore/commit/f66bd146e510747b5a62f02e05e73b1f12260b95)) * Update dependency com.google.cloud:sdk-platform-java-config to v3.50.1 ([#1908](https://togithub.com/googleapis/java-datastore/issues/1908)) ([fa51122](https://togithub.com/googleapis/java-datastore/commit/fa511229d65e9c50e79dfa841aaa348f8a05986f)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).

…p/templates/java_library/.kokoro (googleapis#1908) (googleapis#1439) build(deps): bump cryptography Bumps [cryptography](https://github.com/pyca/cryptography) from 41.0.3 to 41.0.6. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@41.0.3...41.0.6) --- updated-dependencies: - dependency-name: cryptography dependency-type: indirect ... Source-Link: googleapis/synthtool@ea6f800 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:81f75d962cd28b7ad10740a643b8069b8fa0357cb495b782eef8560bb7a8fd65 Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…v3.43.0 (googleapis#1908) * deps: update dependency com.google.cloud:sdk-platform-java-config to v3.43.0 * initialize Dialect$2 as part of strict-image-heap enforcement * Revert "initialize Dialect$2 as part of strict-image-heap enforcement" This reverts commit 7cb4d3a2c5fca89737744c7b48b05d74eed8edc8. * Reapply "initialize Dialect$2 as part of strict-image-heap enforcement" This reverts commit 292f05921acfebb8a834dcb1c457be5c0915f9c4. * initialize Dialect$1 at build time * initialize immutable map entry at build time * initialize subclass of immutable map entry * initialize database dialect $1 * add test class initialization * add test class initialization ii * move parameterized initialization to production config * move junit config to test config * Revert "move junit config to test config" This reverts commit d78fe2f5ff06c0675054deaf95fb9b709fae796f. * include runwith in initialized junit classes * add junit method order to image heap * add junit's category to image heap * remove java.lang.annotation from image heap * initialize parameterized junit class at build time * initialize framework in image-heap * initialize it test parameter at build time explicitly * explicitly initialize singleton immutablebimap --------- Co-authored-by: diegomarquezp <diegomarquezp@google.com>

…p/templates/java_library/.kokoro (#1908) (#2752) build(deps): bump cryptography Bumps [cryptography](https://github.com/pyca/cryptography) from 41.0.3 to 41.0.6. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@41.0.3...41.0.6) --- updated-dependencies: - dependency-name: cryptography dependency-type: indirect ... Source-Link: googleapis/synthtool@ea6f800 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:81f75d962cd28b7ad10740a643b8069b8fa0357cb495b782eef8560bb7a8fd65 Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…p/templates/java_library/.kokoro (#1908) (#1309) build(deps): bump cryptography Bumps [cryptography](https://github.com/pyca/cryptography) from 41.0.3 to 41.0.6. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@41.0.3...41.0.6) --- updated-dependencies: - dependency-name: cryptography dependency-type: indirect ... Source-Link: googleapis/synthtool@ea6f800 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:81f75d962cd28b7ad10740a643b8069b8fa0357cb495b782eef8560bb7a8fd65 Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sydney Munro <97561403+sydney-munro@users.noreply.github.com>

) * chore: Add ObsoleteApi annotation * chore: Add tests for serializing ImpersonatedCredentials * chore: Restore old code * chore: Update error message * chore: Fix failing test issue * chore: Remove old tests referecing obsolete api functionality Original-PR: googleapis/google-auth-library-java#1908

…p/templates/java_library/.kokoro (#1908) (#1309) build(deps): bump cryptography Bumps [cryptography](https://github.com/pyca/cryptography) from 41.0.3 to 41.0.6. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@41.0.3...41.0.6) --- updated-dependencies: - dependency-name: cryptography dependency-type: indirect ... Source-Link: googleapis/synthtool@ea6f800 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:81f75d962cd28b7ad10740a643b8069b8fa0357cb495b782eef8560bb7a8fd65 Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sydney Munro <97561403+sydney-munro@users.noreply.github.com>

…p/templates/java_library/.kokoro (#1908) (#1843) build(deps): bump cryptography Bumps [cryptography](https://github.com/pyca/cryptography) from 41.0.3 to 41.0.6. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@41.0.3...41.0.6) --- updated-dependencies: - dependency-name: cryptography dependency-type: indirect ... Source-Link: googleapis/synthtool@ea6f800 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:81f75d962cd28b7ad10740a643b8069b8fa0357cb495b782eef8560bb7a8fd65 Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Diego Marquez <diegomarquezp@google.com>

…o v1.126.4 (#1908) * chore(deps): update dependency com.google.cloud:google-cloud-pubsub to v1.126.4 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

…p/templates/java_library/.kokoro (#1908) (#1843) build(deps): bump cryptography Bumps [cryptography](https://github.com/pyca/cryptography) from 41.0.3 to 41.0.6. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@41.0.3...41.0.6) --- updated-dependencies: - dependency-name: cryptography dependency-type: indirect ... Source-Link: googleapis/synthtool@ea6f800 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:81f75d962cd28b7ad10740a643b8069b8fa0357cb495b782eef8560bb7a8fd65 Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Diego Marquez <diegomarquezp@google.com>

…o v1.126.4 (#1908) * chore(deps): update dependency com.google.cloud:google-cloud-pubsub to v1.126.4 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

shinfan requested review from garrettjonesgoogle, jskeet and michaelbausor April 12, 2017 21:02

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 12, 2017

garrettjonesgoogle reviewed Apr 12, 2017

View reviewed changes

shinfan force-pushed the master branch from 10218d7 to 851e93c Compare April 13, 2017 21:12

jskeet reviewed Apr 19, 2017

View reviewed changes

shinfan force-pushed the master branch from 851e93c to 14fae1e Compare May 18, 2017 07:40

Add Labels to BucketInfo

b37a624

shinfan force-pushed the master branch from 14fae1e to b37a624 Compare June 26, 2017 22:31

shinfan closed this Jul 18, 2017

chingor13 pushed a commit that referenced this pull request Jan 22, 2026

deps: update dependency com.google.cloud:sdk-platform-java-config to …

b10e0f0

…v3.50.1 (#1908) Co-authored-by: Cindy Peng <148148319+cindy-peng@users.noreply.github.com>

lqiu96 pushed a commit that referenced this pull request Mar 20, 2026

deps: update dependency com.google.cloud:sdk-platform-java-config to …

fa51122

…v3.50.1 (#1908) Co-authored-by: Cindy Peng <148148319+cindy-peng@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Make sure Storage does not do name normalization#1908

Make sure Storage does not do name normalization#1908
shinfan wants to merge 1 commit into
googleapis:mastergoogleapis/google-cloud-java:masterfrom
shinfan:mastershinfan/gcloud-java:masterCopy head branch name to clipboard

shinfan commented Apr 12, 2017

Uh oh!

jskeet commented Apr 12, 2017

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

shinfan commented Apr 12, 2017

Uh oh!

coveralls commented Apr 12, 2017

Uh oh!

coveralls commented Apr 13, 2017

Uh oh!

This comment was marked as spam.

Uh oh!

coveralls commented May 18, 2017

Uh oh!

shinfan commented May 18, 2017

Uh oh!

coveralls commented Jun 26, 2017

Uh oh!

garrettjonesgoogle commented Jul 18, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Search code, repositories, users, issues, pull requests...

Uh oh!

Conversation

shinfan commented Apr 12, 2017

Uh oh!

jskeet commented Apr 12, 2017

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

shinfan commented Apr 12, 2017

Uh oh!

coveralls commented Apr 12, 2017

Uh oh!

coveralls commented Apr 13, 2017

Uh oh!

This comment was marked as spam.

Uh oh!

coveralls commented May 18, 2017

Uh oh!

shinfan commented May 18, 2017

Uh oh!

coveralls commented Jun 26, 2017

Uh oh!

garrettjonesgoogle commented Jul 18, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants