Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

rename shaded.cloud-nio to shaded.cloud_nio#1767

Merged
garrettjonesgoogle merged 1 commit into
googleapis:mastergoogleapis/google-cloud-java:masterfrom
jean-philippe-martin:rename_packagejean-philippe-martin/gcloud-java:rename_packageCopy head branch name to clipboard
Mar 17, 2017
Merged

rename shaded.cloud-nio to shaded.cloud_nio#1767
garrettjonesgoogle merged 1 commit into
googleapis:mastergoogleapis/google-cloud-java:masterfrom
jean-philippe-martin:rename_packagejean-philippe-martin/gcloud-java:rename_packageCopy head branch name to clipboard

Conversation

@jean-philippe-martin

Copy link
Copy Markdown

Because that's a valid package name.

Because that's a valid package name.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 17, 2017
@garrettjonesgoogle

Copy link
Copy Markdown
Contributor

LGTM

@jean-philippe-martin

Copy link
Copy Markdown
Author

the failure's a time out, I don't see any detail for exactly why it was slow.

@garrettjonesgoogle

Copy link
Copy Markdown
Contributor

That one has been failing randomly recently. I restarted it.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 81.486% when pulling 3c25904 on jean-philippe-martin:rename_package into 20777d3 on GoogleCloudPlatform:master.

@garrettjonesgoogle

Copy link
Copy Markdown
Contributor

tests passed!

@jean-philippe-martin

Copy link
Copy Markdown
Author

yay! We can merge it in now!

@garrettjonesgoogle garrettjonesgoogle merged commit e9c05a5 into googleapis:master Mar 17, 2017
@jean-philippe-martin jean-philippe-martin deleted the rename_package branch March 18, 2017 00:10
meltsufin pushed a commit that referenced this pull request Dec 22, 2025
* chore(main): release 3.21.4

* chore: generate libraries at Wed Feb 26 16:31:40 UTC 2025

* chore: generate libraries at Wed Feb 26 16:51:18 UTC 2025

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: cloud-java-bot <cloud-java-bot@google.com>
Co-authored-by: Joe Wang <joewa@google.com>
chingor13 pushed a commit that referenced this pull request Feb 24, 2026
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 11, 2026
* chore(main): release 3.21.4

* chore: generate libraries at Wed Feb 26 16:31:40 UTC 2025

* chore: generate libraries at Wed Feb 26 16:51:18 UTC 2025

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: cloud-java-bot <cloud-java-bot@google.com>
Co-authored-by: Joe Wang <joewa@google.com>
chingor13 pushed a commit that referenced this pull request Mar 12, 2026
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 23, 2026
suztomo pushed a commit that referenced this pull request Mar 30, 2026
Because that's a valid package name.
lqiu96 pushed a commit that referenced this pull request Apr 1, 2026
Because that's a valid package name.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.