Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Remove deprecated methods and corresponding tests#1678

Merged
shinfan merged 10 commits into
googleapis:mastergoogleapis/google-cloud-java:masterfrom
shinfan:devshinfan/gcloud-java:devCopy head branch name to clipboard
Mar 7, 2017
Merged

Remove deprecated methods and corresponding tests#1678
shinfan merged 10 commits into
googleapis:mastergoogleapis/google-cloud-java:masterfrom
shinfan:devshinfan/gcloud-java:devCopy head branch name to clipboard

Conversation

@shinfan

@shinfan shinfan commented Mar 1, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

Update:

Fixed all malformed javadocs including:

  • Deprecated method references
  • Unqualified class names
  • Typos

Note: I intend to merge this PR soon since it may cause lots of conflicts.

Remove deprecated methods and tests in one pass by a self-made script, with a few exceptions:

  • There are still plenty of manual work involved to update usages of deprecated methods and fields
  • Manual corrections due to misspell of the word "deprecated"
  • google-cloud-pubsub: Pubsub has a few deprecated packages and it affects its integrated tests as well. Removing deprecated packages is not in the scope of this PR.
  • google-cloud-compute: Compute engine has a few "Deprecated" related service which causes lots of noise of the automated script.
  • google-cloud-datastore
    • In ValueBuilder getExcludeFromIndexes was marked as deprecated which is inconsistent with other getter/setter methods
    • Preserved the fields meaning in ValueBuilder since it is still wide used in the code. May require a separate PR to deprecate.

Fixes #1569

Test: All unit tests passed locally.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 1, 2017
@garrettjonesgoogle

garrettjonesgoogle commented Mar 3, 2017

Copy link
Copy Markdown
Contributor

It looks like there are javadoc failures in the jdk8 test. I think those should be fixed. Those kind of errors will block the release process.

@shinfan

shinfan commented Mar 3, 2017

Copy link
Copy Markdown
Contributor Author

Seems like we have several javadocs which refer to the deprecated methods. I will go through the repo and fix them.

@coveralls

coveralls commented Mar 4, 2017

Copy link
Copy Markdown

Coverage Status

Changes Unknown when pulling 1bf2b50 on shinfan:dev into ** on GoogleCloudPlatform:master**.

@coveralls

coveralls commented Mar 7, 2017

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.2%) to 81.437% when pulling 686270d on shinfan:dev into bf8df09 on GoogleCloudPlatform:master.

@coveralls

coveralls commented Mar 7, 2017

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.2%) to 81.429% when pulling 5b98eca on shinfan:dev into bf8df09 on GoogleCloudPlatform:master.

garrettjonesgoogle
garrettjonesgoogle reviewed Mar 7, 2017
View reviewed changes

@garrettjonesgoogle garrettjonesgoogle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just have a couple nits - you can choose to take care of them in a following PR if you would like.

LGTM after conflicts are resolved - please merge ASAP since this is so large.

Comment thread google-cloud-datastore/src/main/java/com/google/cloud/datastore/RawValue.java
builder.set(valuePb);
return builder;
}
}

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread google-cloud-datastore/src/main/java/com/google/cloud/datastore/Value.java Outdated
: valueType.getMarshaller().fromProto(proto).build();
}
}
} No newline at end of file

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread google-cloud-datastore/src/main/java/com/google/cloud/datastore/ValueBuilder.java Outdated

P build();
}
} No newline at end of file

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/MessageReceiver.java Outdated
package com.google.cloud.pubsub.spi.v1;

import com.google.pubsub.v1.PubsubMessage;
import java.util.concurrent.BlockingQueue;

This comment was marked as spam.

Sign in to view

@garrettjonesgoogle garrettjonesgoogle mentioned this pull request Mar 7, 2017
Merged
@shinfan shinfan merged commit 5cbbbae into googleapis:master Mar 7, 2017
@coveralls

coveralls commented Mar 7, 2017

Copy link
Copy Markdown

Coverage Status

Changes Unknown when pulling 7441280 on shinfan:dev into ** on GoogleCloudPlatform:master**.

rybosome pushed a commit to rybosome/google-cloud-java that referenced this pull request Mar 9, 2017
@shinfan @rybosome
Remove deprecated methods and corresponding tests (googleapis#1678)
99aef2e 
Remove deprecated methods and its references in one pass by a self-made script, with a few exceptions:
- There are still plenty of manual work involved to update usages of deprecated methods and fields
- Manual corrections due to misspell of the word "deprecated"
- google-cloud-pubsub: Pubsub has a few deprecated packages and it affects its integrated tests as well. Removing deprecated packages is not in the scope of this PR.
- google-cloud-compute: Compute engine has a few "Deprecated" related service which causes lots of noise of the automated script. 
- google-cloud-datastore
  - In `ValueBuilder` `getExcludeFromIndexes` was marked as deprecated which is inconsistent with other getter/setter methods
  - Preserved the fields `meaning` in `ValueBuilder` since it is still wide used in the code. May require a separate PR to deprecate.
@tcoffee-google tcoffee-google mentioned this pull request Jun 6, 2017
Closed
meltsufin pushed a commit that referenced this pull request Dec 22, 2025
@release-please
chore(main): release 3.20.1 (#1678)
be5a63e 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
chingor13 pushed a commit that referenced this pull request Jan 22, 2026
@renovate-bot @cindy-peng
chore(deps): update dependency com.google.cloud:libraries-bom to v26.…
c308e4c 
…51.0 (#1678)

Co-authored-by: Cindy Peng <148148319+cindy-peng@users.noreply.github.com>
chingor13 pushed a commit that referenced this pull request Feb 24, 2026
@renovate-bot
chore(deps): update dependency org.apache.maven.plugins:maven-compile…
37d2284 
…r-plugin to v3.14.0 (#1678)
suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 11, 2026
@release-please
chore(main): release 3.20.1 (googleapis#1678)
8767c24 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
chingor13 pushed a commit that referenced this pull request Mar 12, 2026
@renovate-bot
chore(deps): update dependency org.apache.maven.plugins:maven-compile…
14c0161 
…r-plugin to v3.14.0 (#1678)
suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 23, 2026
@release-please
chore(main): release 2.20.2 (googleapis#1678)
4492913 
🤖 I have created a release *beep* *boop*
---


## [2.20.2](https://togithub.com/googleapis/java-spanner-jdbc/compare/v2.20.1...v2.20.2) (2024-08-07)


### Bug Fixes

* Support getShort for DATA_TYPE in TypeInfo ([googleapis#1691](https://togithub.com/googleapis/java-spanner-jdbc/issues/1691)) ([8c3dd24](https://togithub.com/googleapis/java-spanner-jdbc/commit/8c3dd24dd662cc4dccaa18c5753792aebef9e4a0))


### Dependencies

* Bump Spanner to 6.72.0 ([googleapis#1698](https://togithub.com/googleapis/java-spanner-jdbc/issues/1698)) ([9e935f5](https://togithub.com/googleapis/java-spanner-jdbc/commit/9e935f500c33ed8413ad3415ccb1725ea754d413))
* Update dependency com.google.api.grpc:proto-google-cloud-trace-v1 to v2.47.0 ([googleapis#1695](https://togithub.com/googleapis/java-spanner-jdbc/issues/1695)) ([2c59ba5](https://togithub.com/googleapis/java-spanner-jdbc/commit/2c59ba5958d3c40bdda89c5d7c71a58501e3424e))
* Update dependency com.google.cloud:google-cloud-trace to v2.47.0 ([googleapis#1696](https://togithub.com/googleapis/java-spanner-jdbc/issues/1696)) ([7db29b4](https://togithub.com/googleapis/java-spanner-jdbc/commit/7db29b4123f514e968f559c907aa24d1acdde2c5))
* Update dependency com.google.cloud:sdk-platform-java-config to v3.33.0 ([googleapis#1693](https://togithub.com/googleapis/java-spanner-jdbc/issues/1693)) ([7b18575](https://togithub.com/googleapis/java-spanner-jdbc/commit/7b1857556cc1b499a81c19d705ecedd2656bb7ef))
* Update dependency com.google.cloud.opentelemetry:exporter-trace to v0.31.0 ([googleapis#1679](https://togithub.com/googleapis/java-spanner-jdbc/issues/1679)) ([f4fcd1a](https://togithub.com/googleapis/java-spanner-jdbc/commit/f4fcd1afc8668f66adee4a3c5843ddf7661f7856))
* Update dependency io.opentelemetry:opentelemetry-bom to v1.40.0 ([googleapis#1676](https://togithub.com/googleapis/java-spanner-jdbc/issues/1676)) ([bc24c27](https://togithub.com/googleapis/java-spanner-jdbc/commit/bc24c277978d80bb9b4a93c9a56dfc15d1b174ba))
* Update dependency org.hamcrest:hamcrest to v3 ([googleapis#1697](https://togithub.com/googleapis/java-spanner-jdbc/issues/1697)) ([2fc58cc](https://togithub.com/googleapis/java-spanner-jdbc/commit/2fc58ccc31f90fae7791edd390e5aa6a94c322a5))
* Update dependency org.springframework.boot:spring-boot-starter-data-jdbc to v3.3.2 ([googleapis#1685](https://togithub.com/googleapis/java-spanner-jdbc/issues/1685)) ([080e860](https://togithub.com/googleapis/java-spanner-jdbc/commit/080e8600316f893b391045d00381acc48e5b2a89))
* Update dependency org.springframework.boot:spring-boot-starter-parent to v3.3.2 ([googleapis#1686](https://togithub.com/googleapis/java-spanner-jdbc/issues/1686)) ([ccd6a9c](https://togithub.com/googleapis/java-spanner-jdbc/commit/ccd6a9c37cbad7371573205e2349fd0b69d557b8))
* Update dependency org.springframework.data:spring-data-bom to v2024.0.2 ([googleapis#1680](https://togithub.com/googleapis/java-spanner-jdbc/issues/1680)) ([4ff9caa](https://togithub.com/googleapis/java-spanner-jdbc/commit/4ff9caab95d81567c6f48733e319f5ecbf443c15))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
suztomo pushed a commit that referenced this pull request Mar 30, 2026
@renovate-bot
deps: update dependency com.google.cloud:google-cloud-storage to v2.5…
54c9b78 
…8.1 (#1678)
lqiu96 pushed a commit that referenced this pull request Apr 1, 2026
@renovate-bot
deps: update dependency com.google.cloud:google-cloud-storage to v2.5…
a47a824 
…8.1 (#1678)
meltsufin pushed a commit that referenced this pull request Apr 29, 2026
@release-please
chore(main): release 1.124.0 (#1678)
b9a1b06 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
meltsufin pushed a commit that referenced this pull request May 1, 2026
@release-please
chore(main): release 1.124.0 (#1678)
6e65579 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pongad pongad Awaiting requested review from pongad
@michaelbausor michaelbausor Awaiting requested review from michaelbausor
1 more reviewer
@garrettjonesgoogle garrettjonesgoogle garrettjonesgoogle left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shinfan @garrettjonesgoogle @coveralls @googlebot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.