Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

de-interfac-ify Subscriber#1539

Merged
pongad merged 2 commits into
googleapis:pubsub-rmgoogleapis/google-cloud-java:pubsub-rmfrom
pongad:concrete-subscriberCopy head branch name to clipboard
Jan 18, 2017
Merged

de-interfac-ify Subscriber#1539
pongad merged 2 commits into
googleapis:pubsub-rmgoogleapis/google-cloud-java:pubsub-rmfrom
pongad:concrete-subscriberCopy head branch name to clipboard

Conversation

@pongad

@pongad pongad commented Jan 16, 2017

Copy link
Copy Markdown
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 16, 2017
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.008%) to 83.121% when pulling 5bd9fb6 on pongad:concrete-subscriber into 19acb03 on GoogleCloudPlatform:pubsub-rm.


final int expectedChannelCount =
Runtime.getRuntime().availableProcessors() * SubscriberImpl.CHANNELS_PER_CORE;
Runtime.getRuntime().availableProcessors() * Subscriber.CHANNELS_PER_CORE;

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

}

public SubscriberStats getStats() {
// TODO: Implement me

This comment was marked as spam.

This comment was marked as spam.

@pongad

pongad commented Jan 18, 2017

Copy link
Copy Markdown
Contributor Author

@garrettjonesgoogle PTAL. I think renaming MessagesProcessor should come in a separate PR.

@garrettjonesgoogle

Copy link
Copy Markdown
Contributor

LGTM

@pongad pongad merged commit 46bc1db into googleapis:pubsub-rm Jan 18, 2017
@pongad pongad deleted the concrete-subscriber branch January 18, 2017 22:55
meltsufin pushed a commit that referenced this pull request Dec 22, 2025
…32.0 (#1539)

* chore(deps): update dependency com.google.cloud:libraries-bom to v26.32.0

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
chingor13 pushed a commit that referenced this pull request Jan 22, 2026
* feat: Adding TraceUtil interface and its implementation to enable Tracing controls via DatastoreOptions (#1431)

* Adding EnabledTraceUtil, DisabledTraceUtil and TraceUtilTest
* Annotating DatastoreOpenTelemetryOptions to be transient as they're not serializable
* Adding google-auth-library-credentials dependency due to https://github.com/googleapis/java-datastore/actions/runs/8944472794/job/24571458116?pr=1431

* feat: Adding Lookup RPC OpenTelemetry Tracing (#1437)

* feat: Adding Lookup RPC OpenTelemetry Tracing
- Removed OpenCensus Tracing
- Added E2E tests with Global and Local OTel SDK
- Moved OTel SDK setup to RemoteDatastoreHelper
- Fixed pom to depend on BOM for all shared dependencies

* feat: Adding Commit RPC Trace Instrumentation (#1440)

- Added end-to-end test for Datastore operationsput, add, update and delete.
- Updated E2E Test to use the namespace correctly for efficient clean-up of test data

* feat: RunQuery trace instrumentation (#1441)

* feat: RunQuery trace instrumentation

* feat: RunAggregationQuery instrumentation (#1447)

* feat: RunQuery trace instrumentation

* Formatting

* Formatting

* Refactor: s/RUNQUERY/RUN_QUERY

* feat: RunAggregationQuery Trace Instrumentation

* Build: retiring test assertions for OpenCensus spans - will be replacing this in hermetic integration tests for OpenTelemetry using in-memory span exports (in addition to ITE2ETraceTest.java).

* Formatting

* Fixing @test annotation missed after merge

* Formatting

* feat: RunQuery trace instrumentation

* Formatting

* Formatting

* Refactor: s/RUNQUERY/RUN_QUERY

* feat: RunAggregationQuery Trace Instrumentation

* Build: retiring test assertions for OpenCensus spans - will be replacing this in hermetic integration tests for OpenTelemetry using in-memory span exports (in addition to ITE2ETraceTest.java).

* Formatting

* Fixing @test annotation missed after merge

* Formatting

* feat: Add Transaction tracing
test: transactionalLookupTest

* test: Transaction test for RunInTransaction - need to fix trace instrumentation for RunIn..

* Adding transaction span names

* TransactionLookupTest

* feat: support for transactional operations
- tested using newTransaction() and runInTransaction()

* Revert "feat: support for transactional operations"

This reverts commit 10341c0b97cbc2025f9f928ce8cb09d5c036a5b3.

* feat: support for transactional operations (#1468)

* feat: support for transactional operations
- tested using newTransaction() and runInTransaction()

* feat: Allocateid tracing (#1488)

* feat: Adding tracing for AllocateIds RPC

* formatting

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* feat: Add tracing for ReserveIds operation (#1490)

- added end-to-end test

* fix: Fixed Span nesting for `ReadWriteTransactionCallable` by using parent SpanContext instead of just parent Context (#1495)

* fix: Fixed the TraceUtil.startSpan method to use `SpanContext` for linking with the parent instead of `Context`.
- This fixes the hierarchy of Spans appearing in a transaction under a Run method.
- Tested using existing transaction test

* Fixed commit reordering and typos

* fix: lint errors

* fix: Refactored the ReadWriteTransactioncallable.call method to use startSpan idiomatically
- TraceUtil.startSpan needs more debugging
- return DefaultTracerProvider instance (no-op) when initializing DisabledTraceUtil - this fixes the unit tests in DatastoreTest.testRunInTransactionWithReadWriteOption

* feat: Added tracing for Transaction.RunQuery (#1499)

* feat: Added span for Transactional RunQuery
- tested

* fix: lint

* fix: patch apply issues

* fix: refactor using boolean flag

* fix: s/startSpan/startSpanWithParentContext

* test: Additional Transaction Testing and cleanup OpenCensus usage (#1505)

* test: newTransactionReadWriteTraceTest

* fix: test literal

* feat: Added tests for transaction cases

* fix: Cleanup OpenCensus dead code

* fix: updating version from 2.20.1 -> 2.21.0

* fix: reverting version from 2.21.0 -> 2.20.1

* fix: Adding an exception to the clirr-maven-plugin for an internal API parameter change from com.google.cloud.datastore.TraceUtil -> com.google.cloud.datastore.telemetry.TraceUtil

* fix: Fixing the differenceType in clirr exception

* fix: add an exception for removal of an internal class (com.google.cloud.datastore.TraceUtil)

* fix: fixing incomplete difference details for type 7005

* fix: Fixing `to` of the difference to be the entire signature

* fix: typo

* test: Adding ITTracingTest to verify events and span attributes (whic… (#1514)

* test: Adding ITTracingTest to verify events and span attributes (which are not verified in ITE2ETracingTest) due to TraceClient API limitations.
- This test uses InMemorySpanExporter to read the generated Otel span data by the test process to verify generated span data as it were before exporting to a backend. None of the span data is exported to a durable backend.
- This test is still an E2E test as it requires a project to send RPCs to.

* fix: fixing compilation error due to missing pom dependency.

* test: Test for AllocateId and ReserveId rpcs

* test: Commit/Put/Update/Delete tests

* test: Added fixes and test for RunQuery event

* test: Additional Transaction tests and AggregationQuery test (#1518)

* test: ReadWrite Transaction test

* test: Added test for Transactional RunQuery and Transaction Rollback

* test: runInTransaction API tracing test
- Fixed setting of common span attributes to spans in runInTransaction
- Removed some gRPC related channel attributes that are not present in this Datastore version, yet.

* fix: Undelete gRPC upgrade docs

* fix: Undo merge mistakes

* fix: Updating span event strings (#1539)

* fix: Fixing user-facing span names in line with go/firestore-client-trace-catalog

* fix: updating bom dependency version to fix https://github.com/googleapis/java-datastore/actions/runs/10256441634/job/28375496112?pr=1539

* Fix: typo in test causing integration test failure (#1556)

https://btx.cloud.google.com/invocations/c11a2e8b-4494-4ddc-a77e-cf2bcbcf5254/targets/cloud-devrel%2Fclient-libraries%2Fjava%2Fjava-datastore%2Fpresubmit%2Fintegration;config=default/log

* fix: opentelemetry-sdk should only be used as a Test Dependency

* fix: Update opentelemetry.version - this also fixes the tests failing in https://github.com/googleapis/java-datastore/actions/runs/10891578591/job/30222786908

* fix: Replacing attribute key values w/ constants

* fix: opentelemetry.version to fix RequireUpperBoundDeps check https://github.com/googleapis/java-datastore/actions/runs/10892403348/job/30225154043?pr=1576

* fix: Create Span hierarchy using parent Span (#1580)

* fix: Replace use of TraceUtil.SpanContext w/ TraceUtil.Context

* fix: Fixing how span hierarchy is created across threads - using Span instead of Context

* fix: cleaning up startSpan(spanName, parentContext) variant

* fix: add TracedReadWriteTransactionCallable to bifurcate tracing enabled/disabled paths for the Transaction callback.
- This change implements the idiomatic way to express nested spans as described in https://opentelemetry.io/docs/languages/java/instrumentation/#create-nested-spans

* fix: cleanup

* fix: cleanup

* fix: cleanup

* fix: formatting and import refactoring

* chore: generate libraries at Thu Sep 19 18:35:54 UTC 2024

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: cloud-java-bot <cloud-java-bot@google.com>
chingor13 pushed a commit that referenced this pull request Feb 24, 2026
…-sdk to v2.0.31 (#1539)

Co-authored-by: gcf-merge-on-green[bot] <60162190+gcf-merge-on-green[bot]@users.noreply.github.com>
suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 11, 2026
…32.0 (googleapis#1539)

* chore(deps): update dependency com.google.cloud:libraries-bom to v26.32.0

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
chingor13 pushed a commit that referenced this pull request Mar 12, 2026
…-sdk to v2.0.31 (#1539)

Co-authored-by: gcf-merge-on-green[bot] <60162190+gcf-merge-on-green[bot]@users.noreply.github.com>
suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 23, 2026
Bumping both Spanner client to 6.62.0 and cloud-sdk-java-config to 3.28.1 at the same time, as bumping them separately causes dependency issues.
suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 23, 2026
🤖 I have created a release *beep* *boop*
---


## [2.16.1](https://togithub.com/googleapis/java-spanner-jdbc/compare/v2.16.0...v2.16.1) (2024-03-22)


### Dependencies

* Bump Spanner client to 6.62.0 ([googleapis#1539](https://togithub.com/googleapis/java-spanner-jdbc/issues/1539)) ([a2c6a11](https://togithub.com/googleapis/java-spanner-jdbc/commit/a2c6a110878e22a799f64d004e9036972f11b5fd))
* Update dependency com.google.cloud:sdk-platform-java-config to v3.28.1 ([googleapis#1537](https://togithub.com/googleapis/java-spanner-jdbc/issues/1537)) ([114c594](https://togithub.com/googleapis/java-spanner-jdbc/commit/114c5942a7cdedcbfade8ffcd41c4c20c98e2b13))
* Update dependency org.postgresql:postgresql to v42.7.3 ([googleapis#1532](https://togithub.com/googleapis/java-spanner-jdbc/issues/1532)) ([ee3ec2d](https://togithub.com/googleapis/java-spanner-jdbc/commit/ee3ec2dede8a3e0e3484395d77321327725b2945))
* Update dependency org.springframework.boot:spring-boot-starter-data-jdbc to v3.2.4 ([googleapis#1540](https://togithub.com/googleapis/java-spanner-jdbc/issues/1540)) ([0fbf884](https://togithub.com/googleapis/java-spanner-jdbc/commit/0fbf88465b52fec400110d2a022c50e2d0cf65ab))
* Update dependency org.springframework.boot:spring-boot-starter-parent to v3.2.4 ([googleapis#1541](https://togithub.com/googleapis/java-spanner-jdbc/issues/1541)) ([90cb755](https://togithub.com/googleapis/java-spanner-jdbc/commit/90cb755ba6b4422cf6efca88caca8bb970bf8458))
* Update dependency org.springframework.data:spring-data-bom to v2023.1.4 ([googleapis#1533](https://togithub.com/googleapis/java-spanner-jdbc/issues/1533)) ([2c55fed](https://togithub.com/googleapis/java-spanner-jdbc/commit/2c55fed9c49bd8c796023c16682728ceef0316d5))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
suztomo pushed a commit that referenced this pull request Mar 30, 2026
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
lqiu96 pushed a commit that referenced this pull request Apr 1, 2026
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.