bigquery: show base64 encode and records in insertAll snippets.#1407
Merged
tswast merged 1 commit intoNov 17, 2016
googleapis:mastergoogleapis/google-cloud-java:masterfrom
tswast:bigquery-insertalltswast/google-cloud-java:bigquery-insertallCopy head branch name to clipboard
Merged
bigquery: show base64 encode and records in insertAll snippets.#1407tswast merged 1 commit intogoogleapis:mastergoogleapis/google-cloud-java:masterfrom tswast:bigquery-insertalltswast/google-cloud-java:bigquery-insertallCopy head branch name to clipboard
tswast merged 1 commit into
googleapis:mastergoogleapis/google-cloud-java:masterfrom
tswast:bigquery-insertalltswast/google-cloud-java:bigquery-insertallCopy head branch name to clipboard
Conversation
96aede3 to
a6cc3f1
Compare
lesv
approved these changes
Nov 16, 2016
Showing a raw base64 string isn't great. Instead, show a way to encode the bytes to a base64 string using Guava's BaseEncoding class. Also, it wasn't clear how to insert values of type record, so show that, too.
a6cc3f1 to
063f902
Compare
Contributor
|
Using Guava in snippets is generally a bad idea. We shouldn't assume that users are familiar with it nor we should show code that depends on it to work |
Contributor
Author
|
Okay. I wasn't sure about that. I wish we could show imports in snippets. What about using classes that are Java 8, only? http://docs.oracle.com/javase/8/docs/api/java/util/Base64.html There wasn't a built-in way to encode Base64 until then. |
chingor13
pushed a commit
that referenced
this pull request
Jan 6, 2026
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
chingor13
pushed a commit
that referenced
this pull request
Jan 22, 2026
🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
chingor13
pushed a commit
that referenced
this pull request
Feb 24, 2026
) * feat: [java] allow passing libraries_bom_version from env * reformat Source-Link: googleapis/synthtool@e36d2f1 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:31aa2ef27b071c2e7844b0eb1d5a24254daff06615b1b138b994dd6345c0b0ea Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Diego Marquez <diegomarquezp@google.com>
chingor13
pushed a commit
that referenced
this pull request
Mar 12, 2026
) * feat: [java] allow passing libraries_bom_version from env * reformat Source-Link: googleapis/synthtool@e36d2f1 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:31aa2ef27b071c2e7844b0eb1d5a24254daff06615b1b138b994dd6345c0b0ea Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Diego Marquez <diegomarquezp@google.com>
suztomo
pushed a commit
to suztomo/google-cloud-java
that referenced
this pull request
Mar 23, 2026
suztomo
pushed a commit
that referenced
this pull request
Mar 30, 2026
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
lqiu96
pushed a commit
that referenced
this pull request
Apr 1, 2026
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Showing a raw base64 string isn't great. Instead, show a way to encode
the bytes to a base64 string using Guava's BaseEncoding class.
Also, it wasn't clear how to insert values of type record, so show that,
too.
@lesv @mziccard PTAL