Reduce gRPC dependency footprint, get rid of duplicate classes by mziccard · Pull Request #1365 · googleapis/google-cloud-java

mziccard · Nov 2, 2016

This reduced gRPC dependencies that we include (in particular in the core module) fixes #1278 for good.

@anthmgoogle @garrettjonesgoogle any chance you can have a look? This can also be done at GAX layer to fix googleapis/gax-java#133. Also, is there a reason why proto artifacts (as grpc-google-iam-v1 or grpc-google-pubsub-v1) depend on the whole grpc-all package? I believe that the dependency list there can be heavily reduced.

coveralls · Nov 2, 2016

Coverage remained the same at 83.896% when pulling d9d23ba on mziccard:reduce-grpc-dependency-footprint into a963ef4 on GoogleCloudPlatform:master.

garrettjonesgoogle · Nov 2, 2016

Maybe I should bump the priority of the dependency change in gax so that you don't have to make this mess.

mziccard · Nov 2, 2016

Actually GAX is not a big issue. We use GAX in our google-cloud-core module, but even with the GAX issue fixed I would still want to exclude some of its gRPC dependency (namely all but grpc-protobuf) ingoogle-cloud-core (to reduce its footprint for those modules that depende on it but don't use gRPC). Then in gRPC-based modules I would still have to re-add all grpc dependencies that I previously excluded.

What is causing this mess is the fact that all proto artifacts depend on grpc-all which is as surprising as unnecessary.

garrettjonesgoogle · Nov 2, 2016

Ahh, the proto artifacts - how much would it help for me to update their dependencies too?

mziccard · Nov 2, 2016

Ahh, the proto artifacts - how much would it help for me to update their dependencies too?

My guess is that they only need grpc-protubuf, if this is really the case I can get rid of all <exclude> elements for them (there's one for each pom.xml in this PR and 2 in the core module's pom.xml).

It's not a problem to send out this PR and then remove the <excludes>. Releasing releasing new proto artifacts for all services might take you some time.

Sign in to view

    </dependency>
+    <dependency>
+      <groupId>io.grpc</groupId>
+      <artifactId>grpc-protobuf</artifactId>


coveralls · Nov 3, 2016

Coverage remained the same at 83.896% when pulling 6be9e2c on mziccard:reduce-grpc-dependency-footprint into a963ef4 on GoogleCloudPlatform:master.

garrettjonesgoogle · Nov 3, 2016

LGTM

mziccard · Nov 3, 2016

@garrettjonesgoogle thanks for reviewing!

…e-plugin to v3.1.2 (#1365)

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* feat: implement query profile * javadoc fixes * add betaapi in a few more places * add some extra tests * add some more ITs * add some more fine grained tests * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

…ation is…" (#1365) This reverts commit 5a2d943.

…e-plugin to v3.1.2 (googleapis#1365)

…ation is…" (#1365) This reverts commit ac8c353.

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.easymock:easymock](http://easymock.org) ([source](https://togithub.com/easymock/easymock)) | `5.0.0` -> `5.0.1` | [![age](https://badges.renovateapi.com/packages/maven/org.easymock:easymock/5.0.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/org.easymock:easymock/5.0.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/org.easymock:easymock/5.0.1/compatibility-slim/5.0.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/org.easymock:easymock/5.0.1/confidence-slim/5.0.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-pubsub).

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.easymock:easymock](http://easymock.org) ([source](https://togithub.com/easymock/easymock)) | `5.0.0` -> `5.0.1` | [![age](https://badges.renovateapi.com/packages/maven/org.easymock:easymock/5.0.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/org.easymock:easymock/5.0.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/org.easymock:easymock/5.0.1/compatibility-slim/5.0.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/org.easymock:easymock/5.0.1/confidence-slim/5.0.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-pubsub).

Reduce gRPC dependency footprint, get rid of duplicate classes

d9d23ba

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 2, 2016

garrettjonesgoogle reviewed Nov 2, 2016

View reviewed changes

Comment thread google-cloud-core/pom.xml

</dependency>

<dependency>

<groupId>io.grpc</groupId>

<artifactId>grpc-protobuf</artifactId>

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Wrap grpc version inside a pom.xml property

6be9e2c

mziccard merged commit 09ad52a into googleapis:master Nov 4, 2016

meltsufin pushed a commit that referenced this pull request Dec 22, 2025

build(deps): update dependency org.apache.maven.plugins:maven-surefir…

7e55872

…e-plugin to v3.1.2 (#1365)

chingor13 pushed a commit that referenced this pull request Jan 6, 2026

chore(main): release 0.131.12-alpha-SNAPSHOT (#1365)

a16a4b4

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

chingor13 pushed a commit that referenced this pull request Feb 24, 2026

Revert "Revert "fix: Issue #1347: ExternalAccountCredentials serializ…

b1096fe

…ation is…" (#1365) This reverts commit 5a2d943.

suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 11, 2026

build(deps): update dependency org.apache.maven.plugins:maven-surefir…

ebfdf9b

…e-plugin to v3.1.2 (googleapis#1365)

chingor13 pushed a commit that referenced this pull request Mar 12, 2026

Revert "Revert "fix: Issue #1347: ExternalAccountCredentials serializ…

19e88f3

…ation is…" (#1365) This reverts commit ac8c353.

suztomo pushed a commit that referenced this pull request Mar 30, 2026

test(deps): update dependency com.google.truth:truth to v1.4.2 (#1365)

d892aef

lqiu96 pushed a commit that referenced this pull request Apr 1, 2026

test(deps): update dependency com.google.truth:truth to v1.4.2 (#1365)

940726d

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Reduce gRPC dependency footprint, get rid of duplicate classes#1365

Reduce gRPC dependency footprint, get rid of duplicate classes#1365
mziccard merged 2 commits into
googleapis:mastergoogleapis/google-cloud-java:masterfrom
mziccard:reduce-grpc-dependency-footprintmziccard/gcloud-java:reduce-grpc-dependency-footprintCopy head branch name to clipboard

mziccard commented Nov 2, 2016

Uh oh!

coveralls commented Nov 2, 2016

Uh oh!

garrettjonesgoogle commented Nov 2, 2016

Uh oh!

mziccard commented Nov 2, 2016

Uh oh!

garrettjonesgoogle commented Nov 2, 2016

Uh oh!

mziccard commented Nov 2, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

coveralls commented Nov 3, 2016

Uh oh!

garrettjonesgoogle commented Nov 3, 2016

Uh oh!

mziccard commented Nov 3, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Search code, repositories, users, issues, pull requests...

Uh oh!

Conversation

mziccard commented Nov 2, 2016

Uh oh!

coveralls commented Nov 2, 2016

Uh oh!

garrettjonesgoogle commented Nov 2, 2016

Uh oh!

mziccard commented Nov 2, 2016

Uh oh!

garrettjonesgoogle commented Nov 2, 2016

Uh oh!

mziccard commented Nov 2, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

coveralls commented Nov 3, 2016

Uh oh!

garrettjonesgoogle commented Nov 3, 2016

Uh oh!

mziccard commented Nov 3, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants