Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Hide string setter for DeprecationStatus timestamps#1127

Merged
mziccard merged 1 commit into
googleapis:mastergoogleapis/google-cloud-java:masterfrom
mziccard:fix-image-timestampmziccard/gcloud-java:fix-image-timestampCopy head branch name to clipboard
Aug 9, 2016
Merged

Hide string setter for DeprecationStatus timestamps#1127
mziccard merged 1 commit into
googleapis:mastergoogleapis/google-cloud-java:masterfrom
mziccard:fix-image-timestampmziccard/gcloud-java:fix-image-timestampCopy head branch name to clipboard

Conversation

@mziccard

Copy link
Copy Markdown
Contributor

This PR fixes #732 on our side.

Since wrongly-formattted timestamps might still be around as part of older deprecated objects we must still save timestamps as strings and expose a string getter. This PR however hides the string setter and repaces todos with explanatory comments.

@mziccard mziccard added the api: compute Issues related to the Compute Engine API. label Jul 22, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 22, 2016
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.01%) to 85.865% when pulling 41036ec on mziccard:fix-image-timestamp into 9549dfc on GoogleCloudPlatform:master.

@mziccard

mziccard commented Aug 8, 2016

Copy link
Copy Markdown
Contributor Author

/cc @lesv

@lesv

lesv commented Aug 8, 2016

Copy link
Copy Markdown
Contributor

LGTM

@mziccard mziccard merged commit e1309f0 into googleapis:master Aug 9, 2016
meltsufin pushed a commit that referenced this pull request Dec 22, 2025
🤖 I have created a release *beep* *boop*
---


### Updating meta-information for bleeding-edge SNAPSHOT release.

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
chingor13 pushed a commit that referenced this pull request Jan 22, 2026
…18.0 (#1127)

* chore(deps): update dependency com.google.cloud:libraries-bom to v26.18.0

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 11, 2026
🤖 I have created a release *beep* *boop*
---


### Updating meta-information for bleeding-edge SNAPSHOT release.

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 23, 2026
suztomo pushed a commit that referenced this pull request Mar 30, 2026
🤖 I have created a release *beep* *boop*
---


## [0.126.7](https://togithub.com/googleapis/java-storage-nio/compare/v0.126.6...v0.126.7) (2023-03-06)


### Dependencies

* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.4.0 ([#1126](https://togithub.com/googleapis/java-storage-nio/issues/1126)) ([0ad5f07](https://togithub.com/googleapis/java-storage-nio/commit/0ad5f07f023233ea9ee3d0823a3b2873390a3c0a))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
lqiu96 pushed a commit that referenced this pull request Apr 1, 2026
🤖 I have created a release *beep* *boop*
---


## [0.126.7](https://togithub.com/googleapis/java-storage-nio/compare/v0.126.6...v0.126.7) (2023-03-06)


### Dependencies

* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.4.0 ([#1126](https://togithub.com/googleapis/java-storage-nio/issues/1126)) ([0ad5f07](https://togithub.com/googleapis/java-storage-nio/commit/0ad5f07f023233ea9ee3d0823a3b2873390a3c0a))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: compute Issues related to the Compute Engine API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Image's deprecationStatus can hold wrongly formatted timestamps

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.