Fix PubSub Iterator pullAsync: add callback to PubSubRpc.pull by mziccard · Pull Request #1048 · googleapis/google-cloud-java

mziccard · Jun 9, 2016

This PR follows from the discussion in #1041 and fixes Future<Iterator<ReceivedMessage>> pullAsync.
PubSubRpc.pull changes signature to PullFuture pull(String). PullFuture extends Future<PullResponse> and allows to register callbacks to the RPC's future so messages can be added to the ack deadline renewer as soon as pulled.

mziccard · Jun 9, 2016

/cc @aozarov

coveralls · Jun 9, 2016

Coverage decreased (-0.03%) to 85.084% when pulling 73f20de on mziccard:pubsub-fix-pull into 2fd2d56 on GoogleCloudPlatform:pubsub-alpha.

Sign in to view

    }
  }

+  private static final class PullFutureImpl implements PullFuture {


aozarov · Jun 9, 2016

Looks good to me. I didn't look at the tests or the doc changes. I will let @lesv do that.

coveralls · Jun 9, 2016

Coverage increased (+0.003%) to 85.113% when pulling 752fab0 on mziccard:pubsub-fix-pull into 2fd2d56 on GoogleCloudPlatform:pubsub-alpha.

mziccard · Jun 9, 2016

Comment fixed. @lesv ready if you want to have al look.

lesv · Jun 13, 2016

Comments look fine
Tests - look fine, but I wonder if we can't test more than we do.
LGTM

…apis#1048)

…telligence to v2.2.13 (#1048) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-video-intelligence](https://togithub.com/googleapis/java-video-intelligence) | `2.2.12` -> `2.2.13` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-video-intelligence/2.2.13/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-video-intelligence/2.2.13/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-video-intelligence/2.2.13/compatibility-slim/2.2.12)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-video-intelligence/2.2.13/confidence-slim/2.2.12)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-video-intelligence).

…1048)

…to v3.10.5 (#1048) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-logging](https://togithub.com/googleapis/java-logging) | `3.10.4` -> `3.10.5` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-logging/3.10.5/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-logging/3.10.5/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-logging/3.10.5/compatibility-slim/3.10.4)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-logging/3.10.5/confidence-slim/3.10.4)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-logging</summary> ### [`v3.10.5`](https://togithub.com/googleapis/java-logging/blob/HEAD/CHANGELOG.md#3105-httpsgithubcomgoogleapisjava-loggingcomparev3104v3105-2022-08-25) [Compare Source](https://togithub.com/googleapis/java-logging/compare/v3.10.4...v3.10.5) ##### Bug Fixes - resource detection for 2nd gen of Cloud Functions works incorrectly ([#1045](https://togithub.com/googleapis/java-logging/issues/1045)) ([dda1d0a](https://togithub.com/googleapis/java-logging/commit/dda1d0a48c3db18b46b8306c3304a79054e9b49c)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-logging).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [google-api-core](https://togithub.com/googleapis/python-api-core) | `==2.8.2` -> `==2.10.2` | [![age](https://badges.renovateapi.com/packages/pypi/google-api-core/2.10.2/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/google-api-core/2.10.2/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/google-api-core/2.10.2/compatibility-slim/2.8.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/google-api-core/2.10.2/confidence-slim/2.8.2)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/google-auth-library-java).

…to v3.10.5 (googleapis#1048) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-logging](https://togithub.com/googleapis/java-logging) | `3.10.4` -> `3.10.5` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-logging/3.10.5/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-logging/3.10.5/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-logging/3.10.5/compatibility-slim/3.10.4)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-logging/3.10.5/confidence-slim/3.10.4)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-logging</summary> ### [`v3.10.5`](https://togithub.com/googleapis/java-logging/blob/HEAD/CHANGELOG.md#3105-httpsgithubcomgoogleapisjava-loggingcomparev3104v3105-2022-08-25) [Compare Source](https://togithub.com/googleapis/java-logging/compare/v3.10.4...v3.10.5) ##### Bug Fixes - resource detection for 2nd gen of Cloud Functions works incorrectly ([#&googleapis#8203;1045](https://togithub.com/googleapis/java-logging/issues/1045)) ([0c738b6](https://togithub.com/googleapis/java-logging/commit/0c738b6a861a2512e287f75d95547cd44ede3d12)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-logging).

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [google-api-core](https://togithub.com/googleapis/python-api-core) | `==2.8.2` -> `==2.10.2` | [![age](https://badges.renovateapi.com/packages/pypi/google-api-core/2.10.2/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/google-api-core/2.10.2/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/google-api-core/2.10.2/compatibility-slim/2.8.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/google-api-core/2.10.2/confidence-slim/2.8.2)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/google-auth-library-java).

…gleapis#1048)

…1048) * chore(java): update gcp-releasetool and cryptography in java requirements file Source-Link: https://togithub.com/googleapis/synthtool/commit/74d0956884c1bb9dc901b52de35ca2bca025a74e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:142286d973c7b6d58186070f203b50058a20a7d7b42147996db24921a18da1b0

mziccard added the api: pubsub Issues related to the Pub/Sub API. label Jun 9, 2016

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 9, 2016

mziccard force-pushed the pubsub-fix-pull branch from 647e7ea to 4be3a7a Compare June 9, 2016 15:21

Fix PubSub Iterator pullAsync: add callback to PubSubRpc.pull

73f20de

mziccard force-pushed the pubsub-fix-pull branch from 4be3a7a to 73f20de Compare June 9, 2016 15:54

aozarov reviewed Jun 9, 2016
View reviewed changes

Comment thread gcloud-java-pubsub/src/main/java/com/google/cloud/pubsub/spi/DefaultPubSubRpc.java Outdated

}

}

private static final class PullFutureImpl implements PullFuture {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Make PullFutureImpl extend SimpleForwardingListenableFuture

752fab0

mziccard merged commit d487307 into googleapis:pubsub-alpha Jun 14, 2016

mziccard added a commit to mziccard/gcloud-java that referenced this pull request Jun 27, 2016

Fix PubSub Iterator pullAsync: add callback to PubSubRpc.pull (google…

337a8ef

…apis#1048)

suztomo pushed a commit that referenced this pull request Feb 1, 2023

deps: update dependency com.google.protobuf:protobuf-bom to v3.21.10 (#…

73c2bb4

…1048)

chingor13 pushed a commit that referenced this pull request Jan 6, 2026

chore(main): release 0.129.9 (#1048)

13cbc1e

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 23, 2026

test(deps): update dependency org.mockito:mockito-core to v4.9.0 (goo…

18ebc0e

…gleapis#1048)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix PubSub Iterator pullAsync: add callback to PubSubRpc.pull#1048

Fix PubSub Iterator pullAsync: add callback to PubSubRpc.pull#1048
mziccard merged 2 commits into
googleapis:pubsub-alphagoogleapis/google-cloud-java:pubsub-alphafrom
mziccard:pubsub-fix-pullmziccard/gcloud-java:pubsub-fix-pullCopy head branch name to clipboard

mziccard commented Jun 9, 2016 •

edited

Loading

Uh oh!

mziccard commented Jun 9, 2016

Uh oh!

coveralls commented Jun 9, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

aozarov commented Jun 9, 2016

Uh oh!

coveralls commented Jun 9, 2016

Uh oh!

mziccard commented Jun 9, 2016

Uh oh!

lesv commented Jun 13, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Search code, repositories, users, issues, pull requests...

Uh oh!

Conversation

mziccard commented Jun 9, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mziccard commented Jun 9, 2016

Uh oh!

coveralls commented Jun 9, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

aozarov commented Jun 9, 2016

Uh oh!

coveralls commented Jun 9, 2016

Uh oh!

mziccard commented Jun 9, 2016

Uh oh!

lesv commented Jun 13, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mziccard commented Jun 9, 2016 •

edited

Loading