Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

DefaultStorageRpc.read setting wrong range #373

Copy link
Copy link
Closed
#375
Closed
DefaultStorageRpc.read setting wrong range#373
#375
Copy link
Assignees
aozarov
Labels
🚨 criticalP0 critical issue. Requires immediate fixP0 critical issue. Requires immediate fixapi: storageIssues related to the Cloud Storage API.Issues related to the Cloud Storage API.triage meI really want to be triaged.I really want to be triaged.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Description

@mziccard
mziccard
opened on Nov 13, 2015
Issue body actions

In DefaultStorageRpc.read we set the content range as:

public byte[] read(StorageObject from, Map<Option, ?> options, long position, int bytes)
    throws StorageException {
  ...
  downloader.setContentRange(position, (int) position + bytes);
  ...
}

Accorting to here positions are inclusive, so we should probably do: downloader.setContentRange(position, (int) position + bytes - 1);

Reactions are currently unavailable

Metadata

Metadata

Assignees

Labels

🚨 criticalP0 critical issue. Requires immediate fixP0 critical issue. Requires immediate fixapi: storageIssues related to the Cloud Storage API.Issues related to the Cloud Storage API.triage meI really want to be triaged.I really want to be triaged.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Type

No type

Fields

No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions
    Morty Proxy This is a proxified and sanitized view of the page, visit original site.