Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

fix(pubsub): respect gRPC dial option when PUBSUB_EMULATOR_HOST is set#10040

Merged
hongalex merged 6 commits into
googleapis:maingoogleapis/google-cloud-go:mainfrom
toga4:pubsub-emulator-grpc-dial-optiontoga4/google-cloud-go:pubsub-emulator-grpc-dial-optionCopy head branch name to clipboard
May 6, 2024
Merged

fix(pubsub): respect gRPC dial option when PUBSUB_EMULATOR_HOST is set#10040
hongalex merged 6 commits into
googleapis:maingoogleapis/google-cloud-go:mainfrom
toga4:pubsub-emulator-grpc-dial-optiontoga4/google-cloud-go:pubsub-emulator-grpc-dial-optionCopy head branch name to clipboard

Conversation

@toga4

@toga4 toga4 commented Apr 25, 2024

Copy link
Copy Markdown
Contributor

Fixes #10039

This implementation was based on the following implementation of Spanner Client.

google-cloud-go/spanner/client.go

Lines 252 to 261 in 4d85153

// Append emulator options if SPANNER_EMULATOR_HOST has been set.
if emulatorAddr := os.Getenv("SPANNER_EMULATOR_HOST"); emulatorAddr != "" {
emulatorOpts := []option.ClientOption{
option.WithEndpoint(emulatorAddr),
option.WithGRPCDialOption(grpc.WithInsecure()),
option.WithoutAuthentication(),
internaloption.SkipDialSettingsValidation(),
}
opts = append(emulatorOpts, opts...)
}

@toga4
toga4 requested a review from shollyman as a code owner April 25, 2024 05:31
@toga4
toga4 requested review from a team April 25, 2024 05:31
@product-auto-label product-auto-label Bot added the api: pubsub Issues related to the Pub/Sub API. label Apr 25, 2024
@hongalex hongalex added the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 30, 2024
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 30, 2024
@hongalex hongalex added the kokoro:run Add this label to force Kokoro to re-run the tests. label May 3, 2024
@hongalex
hongalex enabled auto-merge (squash) May 3, 2024 18:47
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label May 3, 2024
@hongalex hongalex added the kokoro:run Add this label to force Kokoro to re-run the tests. label May 3, 2024
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label May 3, 2024
@hongalex hongalex added the kokoro:run Add this label to force Kokoro to re-run the tests. label May 6, 2024
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label May 6, 2024
@hongalex
hongalex merged commit 95bf6b2 into googleapis:main May 6, 2024
@release-please release-please Bot mentioned this pull request May 6, 2024
Merged
@toga4
toga4 deleted the pubsub-emulator-grpc-dial-option branch May 6, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hongalex hongalex hongalex approved these changes
@shollyman shollyman Awaiting requested review from shollyman

Assignees

No one assigned

Labels

api: pubsub Issues related to the Pub/Sub API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

pubsub: gRPC Dial Option is ignored if PUBSUB_EMULATOR_HOST is set

3 participants

@toga4 @hongalex @kokoro-team
Morty Proxy This is a proxified and sanitized view of the page, visit original site.