Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

Commit 3f88a24

Browse filesBrowse files
darkfelinegkevinzhengchalmerloweparthea
authored
fix: Use user_verification=preferred for ReAuth WebAuthn challenge (#1798)
Since ReAuth is a second factor credential, it is not necessary to require UV here. This was discussed with ReAuth folks. Also, in practice, downstream clients disregard this because the U2F protocol doesn't expose UV enforcement. --------- Co-authored-by: Kevin Zheng <147537668+gkevinzheng@users.noreply.github.com> Co-authored-by: Chalmer Lowe <chalmerlowe@google.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>
1 parent f32301a commit 3f88a24
Copy full SHA for 3f88a24

2 files changed

+2-2Lines changed: 2 additions & 2 deletions

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎google/oauth2/challenges.py‎

Copy file name to clipboardExpand all lines: google/oauth2/challenges.py
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,7 @@ def _obtain_challenge_input_webauthn(self, metadata, webauthn_handler):
225225
challenge=self._unpadded_urlsafe_b64recode(challenge),
226226
timeout_ms=WEBAUTHN_TIMEOUT_MS,
227227
allow_credentials=allow_credentials,
228-
user_verification="required",
228+
user_verification="preferred",
229229
extensions=extension,
230230
)
231231

Collapse file

‎tests/oauth2/test_challenges.py‎

Copy file name to clipboardExpand all lines: tests/oauth2/test_challenges.py
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,7 @@ def test_security_key_webauthn():
235235
challenge=challenge._unpadded_urlsafe_b64recode(sk_challenge["challenge"]),
236236
timeout_ms=challenges.WEBAUTHN_TIMEOUT_MS,
237237
allow_credentials=allow_credentials,
238-
user_verification="required",
238+
user_verification="preferred",
239239
extensions=extension,
240240
)
241241

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.