This repository was archived by the owner on Mar 26, 2026. It is now read-only.
fix: mark server_streaming method as async#1502
Closed
Mariatta wants to merge 4 commits into
maingoogleapis/gapic-generator-python:mainfrom
fix-server-streaming-asyncgoogleapis/gapic-generator-python:fix-server-streaming-asyncCopy head branch name to clipboard
Closed
fix: mark server_streaming method as async#1502Mariatta wants to merge 4 commits intomaingoogleapis/gapic-generator-python:mainfrom fix-server-streaming-asyncgoogleapis/gapic-generator-python:fix-server-streaming-asyncCopy head branch name to clipboard
Mariatta wants to merge 4 commits into
maingoogleapis/gapic-generator-python:mainfrom
fix-server-streaming-asyncgoogleapis/gapic-generator-python:fix-server-streaming-asyncCopy head branch name to clipboard
Conversation
4 tasks
parthea
suggested changes
Jan 5, 2023
parthea
left a comment
Contributor
There was a problem hiding this comment.
This would be a breaking change. Please open an issue first to discuss implementation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As found in https://github.com/googleapis/python-bigtable/pull/702/files#diff-cefca7c885a9bf43a6cc4769c788d30041fcffc582df926b7240e03beea308ebR529
In
google/cloud/bigtable_v2/services/bigtable/async_client.pyfile,mutate_rowsshould become a coroutine.and the call to the rpc should be awaited.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #1503 🦕