tests: relax RMSNorm tolerance to fix GPU precision failures - #718
#718Open
AbhishekGiri04 wants to merge 1 commit into
google-deepmind:maingoogle-deepmind/gemma:mainfrom
AbhishekGiri04:fix/rmsnorm-gpu-toleranceAbhishekGiri04/gemma:fix/rmsnorm-gpu-toleranceCopy head branch name to clipboard
Open
tests: relax RMSNorm tolerance to fix GPU precision failures#718AbhishekGiri04 wants to merge 1 commit intogoogle-deepmind:maingoogle-deepmind/gemma:mainfrom AbhishekGiri04:fix/rmsnorm-gpu-toleranceAbhishekGiri04/gemma:fix/rmsnorm-gpu-toleranceCopy head branch name to clipboard
AbhishekGiri04 wants to merge 1 commit into
google-deepmind:maingoogle-deepmind/gemma:mainfrom
AbhishekGiri04:fix/rmsnorm-gpu-toleranceAbhishekGiri04/gemma:fix/rmsnorm-gpu-toleranceCopy head branch name to clipboard
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #32
Replaced assert_array_equal with assert_allclose(rtol=1e-5, atol=1e-5) in test_rmsnorm to handle floating point precision differences on NVIDIA GPUs (V100/A100).