Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Added pkg-config file and .gitignore - #55

#55
Closed
oxoocoffee wants to merge 2 commits into
google:mastergoogle/snappy:masterfrom
oxoocoffee:masterCopy head branch name to clipboard
Closed

Added pkg-config file and .gitignore#55
oxoocoffee wants to merge 2 commits into
google:mastergoogle/snappy:masterfrom
oxoocoffee:masterCopy head branch name to clipboard

Conversation

@oxoocoffee

Copy link
Copy Markdown

I was trying to build mongo-c-driver 1.7.0 on Mac OS X and it was failing to detect since missing pc file

@googlebot

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@oxoocoffee

Copy link
Copy Markdown
Author

I signed it!

Comment thread cmake/snappy.pc.in
@@ -0,0 +1,10 @@
prefix=@CMAKE_INSTALL_PREFIX@
exec_prefix=@CMAKE_INSTALL_PREFIX@
libdir=@CMAKE_INSTALL_PREFIX@/lib

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would really use include(GNUInstallDirs) and not hardcode lib.

@cmumford

Copy link
Copy Markdown
Contributor

@googlebot rescan

@googlebot

Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@lavoiesl

Copy link
Copy Markdown

Any update on this PR?

I’m unable to compile the snappy ruby gem on nix because it can't detect the correct paths. This would be fixed by having a pkg config file.

@pwnall

pwnall commented Nov 10, 2019

Copy link
Copy Markdown
Member

We will not add pkg-config support for now.

We don't want to get into supporting individual package managers, because the C++ ecosystem hasn't converged into a single solution, and there are quite a few equally reasonable candidates. We can't justify the investment into supporting all the package managers, or into supporting a couple of package managers and trying to rationalize where we drew the line.

@pwnall pwnall closed this Nov 10, 2019
@lovesegfault

Copy link
Copy Markdown

@pwnall By now pkg-config is a crucial part of the C/++ ecosystem, in particular for developers downstream trying to build bindings or link snappy into their non-C/++ projects.

I ended up on this issue because I need to link snappy into a Rust binary and have to write special code only for snappy because it doesn't provide a pc file.

Given that the complexity cost of this change is very small (24 lines) I ask you to please reconsider this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.