Interactive mode: Mention IPython REPL requirement#383
Merged
Merged
Interactive mode: Mention IPython REPL requirement#383
Conversation
Mention that the ipython package is an optional requirement for using the IPython REPL, as described in the [source file](https://github.com/google/python-fire/blob/master/fire/interact.py#L17).
Collaborator
|
If you sign the CLA, happy to merge this PR. |
Contributor
Author
|
Thanks for the reminder, just signed it :-) |
Contributor
Author
|
Unfortunately, I'm getting a 400 error when trying to rescan the CLA. Does someone have experience with this error or could someone else please try to trigger the rescan?
|
Collaborator
|
That's unexpected. https://cla.developers.google.com/ is the url for the cla -- that giving you a 404 is strange. |
Collaborator
|
That was easier than expected :) |
Contributor
Author
|
Perfect, thanks :-) |
Contributor
Author
|
Is there something else that I should do before you could merge? |
vincentkoc
approved these changes
Jun 5, 2022
dbieber
pushed a commit
to wchliao/python-fire
that referenced
this pull request
Dec 9, 2022
Mention that the ipython package is an optional requirement for using the IPython REPL, as described in the [source file](https://github.com/google/python-fire/blob/master/fire/interact.py#L17).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mention that the ipython package is an optional requirement for using the IPython REPL, as described in the source file.