Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add text inputs support for Beam module#169

Open
mtsokol wants to merge 1 commit into
google:maingoogle/array_record:mainfrom
mtsokol:conversion-tutorialmtsokol/array_record:conversion-tutorialCopy head branch name to clipboard
Open

Add text inputs support for Beam module#169
mtsokol wants to merge 1 commit into
google:maingoogle/array_record:mainfrom
mtsokol:conversion-tutorialmtsokol/array_record:conversion-tutorialCopy head branch name to clipboard

Conversation

@mtsokol

@mtsokol mtsokol commented Jul 30, 2025

Copy link
Copy Markdown
Contributor

Hi @iindyk,

This PR adds support for text inputs for Beam module and cleans up Beam docs a bit.

@iindyk iindyk requested a review from dryman July 31, 2025 22:05
@iindyk

iindyk commented Jul 31, 2025

Copy link
Copy Markdown
Collaborator

@dryman Felix, please take a look

@dryman dryman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the slow review.

Could you add a beam test for your changes in the pipeline? It makes your PR more solid and would prevent future code changes the intended behaviors.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.