Use wp_safe_remote_get() to retreive remote .ics data#2614
Merged
Merged
Use wp_safe_remote_get() to retreive remote .ics data#2614
Conversation
EvanHerman
requested review from
AnthonyLedesma,
jrtashjian,
olafleur and
snovosel
June 20, 2024 19:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
.icsparser was usingfetch()to retrieve remote .ics file data. This PR useswp_safe_remote_get()when retrieving remote .ics file data instead and removes any reference tofetch()since we do not allow local .ics files to be used.Additional changes to the Ci/CD workflow:
.nvmrcto 18 to use Node v18 in the workflows@wordpress/envto 10.1.0@wordpress/scriptsto 28.1.0Screenshots
Types of changes
Bug fix (non-breaking change which fixes an issue)
How has this been tested?
Tested retrieving a remote .ics file from a Github account. (Note: The .ics file must have events in the future, or current day. If they have passed, they will not show up)
Acceptance criteria
Use
wp_safe_remote_get()instead offetch()to retrieve remote .ics file data, and ensure things still work as it does in its current state.Checklist: