Fix tests that are broken under Python 2.7.#86
Closed
marcusrbrown wants to merge 2 commits into
gitpython-developers:0.3gitpython-developers/GitPython:0.3from
marcusrbrown:fix/0.3/py2.7-unittestCopy head branch name to clipboard
Closed
Fix tests that are broken under Python 2.7.#86marcusrbrown wants to merge 2 commits intogitpython-developers:0.3gitpython-developers/GitPython:0.3from marcusrbrown:fix/0.3/py2.7-unittestCopy head branch name to clipboard
marcusrbrown wants to merge 2 commits into
gitpython-developers:0.3gitpython-developers/GitPython:0.3from
marcusrbrown:fix/0.3/py2.7-unittestCopy head branch name to clipboard
Conversation
Member
|
Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Python 2.7, the unittest module was revamped to match the Python 3 version. Python 2.7 unittest doesn't run class fixtures if the class method isn't named setUpClass(). This fixes the tests that throw AttributeError under Python 2.7 (also mentioned in Issues #20 and #62):
I also tested under Python 2.6 to ensure that those tests would still run. I have a similar patch incoming on master.