Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Allow mmap not just for py2.6, 2.7 and 3.6+ but also 3.0+ #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Byron merged 1 commit into from
Mar 18, 2018
Merged

Allow mmap not just for py2.6, 2.7 and 3.6+ but also 3.0+ #736

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions 10 git/index/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
import os
from stat import S_ISLNK
import subprocess
import sys
import tempfile

from git.compat import (
Expand All @@ -18,7 +17,6 @@
force_bytes,
defenc,
mviter,
is_win
)
from git.exc import (
GitCommandError,
Expand Down Expand Up @@ -128,13 +126,7 @@ def _set_cache_(self, attr):
lfd.rollback()
# END exception handling

# Here it comes: on windows in python 2.5, memory maps aren't closed properly
# Hence we are in trouble if we try to delete a file that is memory mapped,
# which happens during read-tree.
# In this case, we will just read the memory in directly.
# Its insanely bad ... I am disappointed !
allow_mmap = (is_win or sys.version_info[1] > 5)
stream = file_contents_ro(fd, stream=True, allow_mmap=allow_mmap)
stream = file_contents_ro(fd, stream=True, allow_mmap=True)

try:
self._deserialize(stream)
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.