Adding support for git remote set-url/get-url API to Remote#446
Adding support for git remote set-url/get-url API to Remote#446Byron merged 2 commits intogitpython-developers:mastergitpython-developers/GitPython:masterfrom guyzmo:updating_remote_url_handlingguyzmo/GitPython:updating_remote_url_handlingCopy head branch name to clipboard
Conversation
|
might need to write some tests for those? |
546dfeb to
ba01785
Compare
|
Oh yes please ! It should be relatively straightforward to deduce how to write tests for this by looking at the existing ones. Usually there are helper functions to setup even more complex fixtures. |
|
Before I forget, could you also look at how existing methods are documented and match the documentation style ? This would include documenting all parameters, for example. |
|
I might, but sadly I'm now in the train, going away for four days, during which I'm on a crappy tablet on which I cannot work. Though, I very much would like to see this new methods included in the next patchset so I can remove the monkey patching from my own codebase as well :-) cf https://github.com/guyzmo/git-repo/blob/master/git_repo/services/service.py#L25-43 |
Both commands enable handling of a little known feature of git, which is to support multiple URL for one remote. You can add multiple url using the `set_url` subcommand of `git remote`. As listing them is also handy, there's a nice method to do it, using `get_url`. * adding set_url method that maps to the git remote set-url command¶ * can be used to set an URL, or replace an URL with optional positional arg¶ * can be used to add, delete URL with kwargs (matching set-url options)¶ * adding add_url, delete_url methods that wraps around set_url for conveniency¶ * adding urls property that yields an iterator over the setup urls for a remote¶ * adding a test suite that checks all use case scenarii of this added API.¶ Signed-off-by: Guyzmo <guyzmo+github@m0g.net>
ba01785 to
b366d3f
Compare
|
So, I've squashed my commit with a new one, featuring a few changes:
Then I've added a couple of convenience methods, to avoid adding awkward arguments to control
Finally, I've added a test covering all the new code, with a couple of edge cases, and wrote pydoc for those functions. I hope it's how you like it, mates! |
…t remote get-url` `get-url` is a new API that is not widely available yet (introduced in git 2.7.0), and provokes failure on travis. Signed-off-by: Guyzmo <guyzmo+github@m0g.net>
c780aff to
3f4b410
Compare
|
can you ping me when you think you'll be able to merge, and publish on pypi¸ and what version that will be? So I can update my setup.py accordingly ☺ |
|
If @nvie doesn't beat me to it, I will get the new release on the way on my next maintenance slot. Maybe tomorrow ... . |
|
thank you ;-) preparing my own code to be ready to point to the right version! :-) |
|
I'll add 2 more bug fixes tonight to this release. After I'm done with those, I'll roll a new release :) |
Both commands enable handling of a little known feature
of git, which is to support multiple URL for one remote.
You can add multiple url using the
set_urlsubcommand ofgit remote. Though listing them is also handy, so there'sa nice method to do it, using the configuration.