Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit dbbcaf7

Browse filesBrowse files
OswinNathanialdpursehouse
OswinNathanial
authored and
dpursehouse
committed
Run os.kill for all child pids even after some of them are down
Right now, we come out of the iteration in case of failure while trying to kill a child pid. This may result in some of the child pids staying alive. Change-Id: I18d58fcefec2bbdae4ae9bf73594939ade241b52
1 parent d06e76b commit dbbcaf7
Copy full SHA for dbbcaf7

1 file changed

+4-1Lines changed: 4 additions & 1 deletion

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎git/cmd.py‎

Copy file name to clipboardExpand all lines: git/cmd.py
+4-1Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -618,7 +618,10 @@ def _kill_process(pid):
618618
try:
619619
os.kill(pid, SIGKILL)
620620
for child_pid in child_pids:
621-
os.kill(child_pid, SIGKILL)
621+
try:
622+
os.kill(child_pid, SIGKILL)
623+
except OSError:
624+
pass
622625
kill_check.set() # tell the main routine that the process was killed
623626
except OSError:
624627
# It is possible that the process gets completed in the duration after timeout

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.