Update publish.yml#66
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the npm publish GitHub Actions workflow to support an OIDC-based publishing flow as part of the referenced OIDC migration effort.
Changes:
- Adds
id-token: writepermission for OIDC token minting. - Updates
actions/checkoutandactions/setup-nodeto@v4and bumps the configured Node.js version. - Switches npm publishing to
npm publish --provenanceand removes use of thenpm_tokensecret.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/publish.yml | Migrates release publishing workflow toward OIDC/provenance-based npm publishing and updates action/node versions. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comments suppressed due to low confidence (1)
.github/workflows/publish.yml:25
- This package is scoped (
@github/task-lists-element), andpackage.jsondoes not definepublishConfig.access. For scoped packages,npm publishcan default to restricted/private and/or fail unless--access public(orpublishConfig.access: public) is set. Consider making the access explicit to avoid a release-time publish failure or accidentally publishing as restricted.
- run: npm --ignore-scripts publish --provenance
- Files reviewed: 1/1 changed files
- Comments generated: 2
| - uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 14 | ||
| node-version: 24 |
| - run: npm whoami; npm --ignore-scripts publish | ||
| env: | ||
| NODE_AUTH_TOKEN: ${{secrets.npm_token}} | ||
| - run: npm --ignore-scripts publish --provenance |
llastflowers
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of: https://github.com/github/web-systems/issues/4309
OIDC migration