Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix using relative URLs in src#13

Merged
muan merged 1 commit into
mastergithub/remote-input-element:masterfrom
relative-urlgithub/remote-input-element:relative-urlCopy head branch name to clipboard
Sep 20, 2019
Merged

Fix using relative URLs in src#13
muan merged 1 commit into
mastergithub/remote-input-element:masterfrom
relative-urlgithub/remote-input-element:relative-urlCopy head branch name to clipboard

Conversation

@muan

@muan muan commented Sep 18, 2019

Copy link
Copy Markdown
Contributor

On http://localhost/demo/remote-input/, <remote-input src="../test"> fetches http://localhost/test instead of http://localhost/demo/test.

This uses window.location.href to set URL so relative URLs are respected.

@muan muan requested a review from a team September 18, 2019 20:33

@dgraham dgraham left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚡️

@muan muan merged commit d903f1f into master Sep 20, 2019
@muan muan deleted the relative-url branch September 23, 2019 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.